Support chunking in the middle of a series in the emitter #6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-6115-chunked-query-support-mid-series
branch
2 times, most recently
from
5b73ec4 to
b62ae06
Compare
jsternberg
force-pushed
the
js-6115-chunked-query-support-mid-series
branch
2 times, most recently
from
106cd51 to
e5574d5
Compare
| // If you want to return more than the default chunk size, then use chunking | ||
| // to process multiple blobs. | ||
| rows += len(r.Series) | ||
| if rows > DefaultChunkSize { |
There was a problem hiding this comment.
Can we make this an http config limit option? Default to 10000 and allow 0 to disable it.
jsternberg
force-pushed
the
js-6115-chunked-query-support-mid-series
branch
from
e5574d5 to
f5f385b
Compare
Limit the maximum size of the return value when chunking is not used to prevent the server from going out of memory. Fixes #6115.
jsternberg
force-pushed
the
js-6115-chunked-query-support-mid-series
branch
from
f5f385b to
364dce3
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6115.