Support chunked queries in the Go InfluxDB client #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-influxdb-client-chunked-output
branch
2 times, most recently
from
f0a3c82
to
01fa852
Compare
| r, err := cr.NextResponse() | ||
| if err != nil { | ||
| // Ignore EOF errors if we got an invalid status code. | ||
| if err == io.EOF && resp.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
NextResponse can't return io.EOF so I don't think you need to check for it here.
There was a problem hiding this comment.
I think that got in there because an earlier version I worked on did have it return EOF. The reason for keeping it there was because EOF can be returned if the server sends a 500. It doesn't appear like it matters where in the code this check is, so I'm going to leave it in the chunked response and remove it from here.
Good catch.
jsternberg
force-pushed
the
js-influxdb-client-chunked-output
branch
from
01fa852
to
2ec6e8b
Compare
If the http.CloseNotifier didn't go off for some reason (and it's not guaranteed to go off just because the HTTP connection is closed), the query wouldn't get correctly recycled when chunked output was requested. The query id in the query executor was also not being set correctly. This seems to have been an oversight when merging the point limit monitor.
Modify the CLI to always use chunked queries.
jsternberg
force-pushed
the
js-influxdb-client-chunked-output
branch
from
2ec6e8b
to
8752d1b
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the CLI to always use chunked queries.