Fix SHOW TAG VALUES condition to not filter "name" erroneously #6584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #6038 was merged, we needed to filter "name" so that it didn't accidentally hit the code path that used "name" to check the name of a measurement. This was changed to "_name" to avoid a conflict with a legitimate tag that used "name" as the key. SHOW TAG VALUES was never modified to remove the code that filtered out "name". This removes that line of code so a condition with "name" doesn't get removed erroneously. Example: SHOW TAG VALUES WITH KEY = host WHERE "name" = 'jsternberg' Fixes #6581.
|
By analyzing the blame information on this pull request, we identified @e-dard and @mark-rushakoff to be potential reviewers |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #6038 was merged, we needed to filter "name" so that it didn't
accidentally hit the code path that used "name" to check the name of a
measurement. This was changed to "_name" to avoid a conflict with a
legitimate tag that used "name" as the key.
SHOW TAG VALUES was never modified to remove the code that filtered out
"name". This removes that line of code so a condition with "name"
doesn't get removed erroneously.
Example:
Fixes #6581.