Fix for merge values #6587
Merged
Fix for merge values #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @joelegasse and @e-dard to be potential reviewers |
| @@ -694,11 +694,19 @@ func (c *Client) DropShard(id uint64) error { | |||
|
|
|||
| // CreateShardGroup creates a shard group on a database and policy for a given timestamp. | |||
| func (c *Client) CreateShardGroup(database, policy string, timestamp time.Time) (*ShardGroupInfo, error) { | |||
| // Check under a read-lock | |||
There was a problem hiding this comment.
I think a little more detail explaining the reason for the optimistic check under read lock would be worthwhile.
There was a problem hiding this comment.
CreateShardGroup is actually CreateShardGroupIfNotExists and shard groups are checked for existence much more frequently than they are created. The write lock showed up in the block profile when writing points w/ many fields.
|
LGTM 👍 Just that question above over whether you could reduce allocations by waiting until you know if you need to merge in an element before reducing the length of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
Discovered two cases where
Mergewould sometimes return values unsorted. This PR fixes those cases. Also discovered some heavy lock contention inCreateShardGroupwhich this PR also fixes.