Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old cluster code #6604

Merged
merged 6 commits into from
May 11, 2016
Merged

Remove old cluster code #6604

merged 6 commits into from
May 11, 2016

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented May 11, 2016

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

This PR removes the old cluster related code and config options. It also renames the config option to [coordinator] since some of the options are related to query and write limits and are still needed. Config's that have [cluster] defined will still load and will be converted to [coordinator] for backwards compatibility. These config options will need to be updated before 1.0 release.

This also adds back the PointsWriter timeout config option that was not actually being used by PointsWriter.

@jwilder jwilder added this to the 1.0.0 milestone May 11, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer

LogQueriesAfter toml.Duration `toml:"log-queries-after"`
MaxSelectPointN int `toml:"max-select-point"`
MaxSelectSeriesN int `toml:"max-select-series"`
MaxSelectBucketsN int `toml:"max-select-buckets"`
Copy link
Contributor

@e-dard e-dard May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default or description about what this (MaxSelectBucketsN) does.

@e-dard
Copy link
Contributor

e-dard commented May 11, 2016

LGTM 👍

@jwilder jwilder merged commit 590b3f9 into master May 11, 2016
@jwilder jwilder deleted the jw-cluster branch May 11, 2016 22:57
@timhallinflux timhallinflux modified the milestones: 1.0.0, 1.0.0 beta Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants