Fix possible deadlock when queries and delete series run concurrently #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This locks showeed up in a deadlock systems running queries and delete series across a large dataset. Queries should not need to lock the tsdb.Store for writes
|
By analyzing the blame information on this pull request, we identified @e-dard to be a potential reviewer |
|
👍 |
|
LGTM 👍 |
This was referenced May 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
This locks showed up in a deadlocked systems running queries and
delete series across a large dataset. Queries should not need to
lock the
tsdb.Storefor writes so this change switch theLockto anRLock.cc @benbjohnson