update go dependencies #7050
update go dependencies #7050
Conversation
corylanou
force-pushed
the
cjl-dep-updates
branch
from
212aac3 to
71085e9
Compare
|
I tested this locally by starting a binary up that didn't have the updates. Loaded a bunch of data for strings, ints, floats, etc. Waited for compaction to run. Then started a new binary with the new dependencies and everything looked good. |
| @@ -63,7 +63,7 @@ func Test_StringEncoder_Multi_Compressed(t *testing.T) { | |||
| t.Fatalf("unexpected encoding: got %v, exp %v", b[0], stringCompressedSnappy) | |||
| } | |||
|
|
|||
| if exp := 47; len(b) != exp { | |||
| if exp := 51; len(b) != exp { | |||
There was a problem hiding this comment.
I looked through the diff of what changed in snappy (golang/snappy@5979233...d9eb7a3) a bit, but it wasn't obvious to me why the encoded length went up by 4 bytes - presumably an implementation detail, maybe it will change again in the future?
Would it be better to just assert that the encoded length is less than some fraction of the input length?
There was a problem hiding this comment.
That would make the test less brittle (still brittle, just less). I'm fine with it. @jwilder thoughts?
There was a problem hiding this comment.
I'd rather keep the length check and have the test fail so someone investigates why as opposed to possibly letting a data corruption bug sneak in quietly.
|
I like the renamed test functions. 👍 from me after you make a decision on the length assertion. |
|
👍 |
Our dependencies were getting fairly out of date. Getting them updated prior to 1.0 GA release.
This is experimental to see how the tests do. We should take a close look at the changes to make sure it won't affect any compatiblity with file encoding,etc.
Here is a list comparisons for each dependency updated in this PR.
BurntSushi/toml@f0aeabc...master
boltdb/bolt@6d4e6a3...master
davecgh/go-spew@fc32781...master
dgrijalva/jwt-go@40bd0f3...9b486c8
dgryski/go-bits@86c69b3...master
dgryski/go-bitstream@27cd597...master
dvsekhvalnov/jose2go@6387d3c...master
gogo/protobuf@74b6e9d...master
golang/snappy@723cc1e...master
jwilder/encoding@b421ab4...master
peterh/liner@82a939e...master
It is important to note that https://github.com/dgrijalva/jwt-go has went through a major upgrade and will require a refactor of our code to re-implement to get to the current version of the package.
Required for all non-trivial PRs
Related to https://github.com/influxdata/plutonium/pull/387