Reduce map allocations when computing the TagSets of a measurement #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benbjohnson can you take a look? |
benbjohnson
suggested changes
Oct 17, 2016
| } | ||
| } | ||
| return ids, filters | ||
| } |
There was a problem hiding this comment.
You can simplify this and remove i/j by using the first element of lids and rids and reslicing.
e.g.
for len(lids) > 0 && len(rids) > 0 {
lid, rid := lids[0], rids[0]
if lid == rid {
// ...compare
lids, rids = lids[1:], rids[1:]
} else if lid < rid {
lids = lids[1:]
} else {
rids = rids[1:]
}
}
jsternberg
force-pushed
the
js-reduce-map-operations-in-tag-sets
branch
from
607b7a8 to
78ff932
Compare
benbjohnson
approved these changes
Oct 17, 2016
jsternberg
force-pushed
the
js-reduce-map-operations-in-tag-sets
branch
from
78ff932 to
d29fc65
Compare
Instead of assigning a boolean value of true to the filter expressions when there was no meaningful expression, this drops a boolean expression of true from the filter expressions so we don't have to perform a map assignment. This allows us to reduce allocations and assignments when a `WHERE` clause only contains tag comparisons and no field comparisons.
jsternberg
force-pushed
the
js-reduce-map-operations-in-tag-sets
branch
from
d29fc65 to
41e4e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assigning a boolean value of true to the filter expressions
when there was no meaningful expression, this drops a boolean expression
of true from the filter expressions so we don't have to perform a map
assignment. This allows us to reduce allocations and assignments when a
WHEREclause only contains tag comparisons and no field comparisons.