Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config file defaults #7510

Merged
merged 3 commits into from
Oct 24, 2016
Merged

Update config file defaults #7510

merged 3 commits into from
Oct 24, 2016
+228 −106

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented Oct 24, 2016 •
edited
Loading

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

This updates the config file to:

  • Have all config options that do not change the default to be commented out
  • Removes old config options that are no longer available
  • Updates config options to new defaults based on prior bugs and tuning
    recommendations
  • Adds documentation to the config options

Fixes #7320
Fixes #7504

Sorry, something went wrong.

@jwilder jwilder added this to the 1.1.0 milestone Oct 24, 2016
@jwilder
Update config file installed by packages

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
eb3b45d 
This updates the config file to:
* Have all config options that do not change the default to be commented
out
* Removes old config options that are no longer available
* Updates config options to new defaults based on prior bugs and tuning
recommendations

Fixes #7320
Fixes #7504
@jwilder
Remove unused config options
686d1a7
@jwilder jwilder force-pushed the jw-config-defaults branch from 00b43e9 to 46b9d77 Compare October 24, 2016 21:32
@jwilder jwilder mentioned this pull request Oct 24, 2016
Closed
4 tasks
e-dard
e-dard approved these changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwilder jwilder force-pushed the jw-config-defaults branch from 46b9d77 to 6249c8b Compare October 24, 2016 22:13
@jwilder jwilder merged commit 74c6a0c into master Oct 24, 2016
@jwilder jwilder deleted the jw-config-defaults branch October 24, 2016 22:39
This was referenced Oct 25, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard

Assignees
No one assigned
Labels
area/packaging
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwilder @e-dard