Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the version string when linking to the documentation #7531

Merged

Conversation

jsternberg
Copy link
Contributor

The admin console would dynamically discover the version from the
InfluxDB server, but for patch releases, it included the patch in the
link to the documentation and that wasn't a valid link.

Truncate the version so the documentation url is correct since we only
do documentation for major.minor.

Fixes #7526.

@jwilder
Copy link
Contributor

jwilder commented Oct 27, 2016

Appveyor failed TestServer_Query_ImplicitEndTime. Looks like a flaky test.

@jsternberg
Copy link
Contributor Author

Huh. I thought I had fixed that test. I'm going to disable it temporarily until I can figure out how to make it non-flaky.

The admin console would dynamically discover the version from the
InfluxDB server, but for patch releases, it included the patch in the
link to the documentation and that wasn't a valid link.

Truncate the version so the documentation url is correct since we only
do documentation for `major.minor`.
@jsternberg jsternberg force-pushed the js-7526-fix-documentation-button-with-patch-versions branch from a923668 to 3e29d3d Compare October 27, 2016 21:40
@jwilder jwilder added this to the 1.1.0 milestone Oct 27, 2016
@jsternberg jsternberg merged commit 017ff22 into master Oct 28, 2016
@jsternberg jsternberg deleted the js-7526-fix-documentation-button-with-patch-versions branch October 28, 2016 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants