introduce a new function non_negative_difference #8235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhexuany
force-pushed
the
non_negative_difference
branch
2 times, most recently
from
45eb48d to
83453c1
Compare
jsternberg
suggested changes
Mar 31, 2017
influxql/functions.go
Outdated
| @@ -216,6 +218,12 @@ func (r *FloatDifferenceReducer) Emit() []FloatPoint { | |||
| // Calculate the difference of successive points. | |||
| value := r.curr.Value - r.prev.Value | |||
|
|
|||
| // if its non_negative_difference discard any negative value. Since | |||
There was a problem hiding this comment.
Can you modify this comment to use proper capitalization and fix the typo in makred to marked?
influxql/parser_test.go
Outdated
| @@ -314,6 +314,56 @@ func TestParser_ParseStatement(t *testing.T) { | |||
| }, | |||
| }, | |||
|
|
|||
| // non_negtative_difference | |||
jsternberg
approved these changes
Mar 31, 2017
|
Can you rebase to a single commit and update the changelog? Then I'll double check that this is OK to merge and hopefully have it done before the end of the day. |
zhexuany
force-pushed
the
non_negative_difference
branch
from
2f30b9b to
232fdae
Compare
|
@jsternberg Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs