TSI Fixes (1.3) #8485
Merged
TSI Fixes (1.3) #8485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
reviewed
Jun 13, 2017
tsdb/index/tsi1/file_set.go
Outdated
| @@ -78,8 +78,9 @@ func (fs *FileSet) MustReplace(oldFiles []File, newFile File) *FileSet { | |||
|
|
|||
| // Ensure all old files are contiguous. | |||
| for j := range oldFiles { | |||
| println("dbg/replace", len(fs.files), "//", i, j) | |||
There was a problem hiding this comment.
Fixed in 400147c.
tsdb/index/tsi1/file_set.go
Outdated
| if fs.files[i+j] != oldFiles[j] { | ||
| panic("cannot replace non-contiguous files") | ||
| panic(fmt.Sprintf("cannot replace non-contiguous files: subset=%+v, fileset=%+v", Files(oldFiles).IDs(), Files(fs.files).IDs())) |
There was a problem hiding this comment.
Is MustReplace only used in tests?
There was a problem hiding this comment.
No, this is called in a goroutine started by compact(). It's an invariant of the code and should not fail. It's an extra check to ensure the index does not get corrupted.
This fixes the case where log files are compacted out of order and cause non-contiguous sets of index files to be compacted. Previously, the compaction planner would fetch a list of index files for each level and compact them in order starting with the oldest ones. This can be a problem for level 1 because level 0 (log files) are compacted individually and in some cases a log file can finish compacting before older log files are finished compacting. This causes there to be a gap in the list of level 1 files that is ignored when fetching a list of index files. Now, the planner reads the list of index files starting from the oldest but stops once it hits a log file. This prevents that gap from being ignored.
jwilder
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking for 1.3:
Required for all non-trivial PRs