Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #8677: check for snapshot size == 0 #8704

Merged
merged 1 commit into from
Aug 16, 2017
Merged

fix #8677: check for snapshot size == 0 #8704

merged 1 commit into from
Aug 16, 2017
+42 −0

Conversation

dgnorton
Copy link
Contributor

@dgnorton dgnorton commented Aug 15, 2017 •
edited
Loading

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

Sorry, something went wrong.

jwilder
jwilder suggested changes Aug 15, 2017
View reviewed changes
tsdb/engine/tsm1/engine.go Outdated
@@ -1117,6 +1117,10 @@ func (e *Engine) WriteSnapshot() error {
return err
}

if snapshot.Size() == 0 {
return nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will also need to run e.Cache.ClearSnapshot(true) in this case. That is currently done in e.writeSnapshotAndCommit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dgnorton dgnorton force-pushed the dn-8677-fix-backup branch from 22fc25f to ec534d4 Compare August 15, 2017 21:27
@dgnorton dgnorton force-pushed the dn-8677-fix-backup branch from ec534d4 to c3d69db Compare August 16, 2017 13:42
@dgnorton dgnorton force-pushed the dn-8677-fix-backup branch from c3d69db to 1d8d739 Compare August 16, 2017 13:44
@dgnorton dgnorton merged commit 9f74c0f into master Aug 16, 2017
@dgnorton dgnorton deleted the dn-8677-fix-backup branch August 16, 2017 13:57
@dgnorton dgnorton mentioned this pull request Aug 16, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgnorton @jwilder