Prevent race condition caused by WaitGroup re-use #9335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mark-rushakoff
approved these changes
Jan 17, 2018
| wg sync.WaitGroup // waitgroup for active level compaction goroutines | ||
| done chan struct{} // channel to signal level compactions to stop | ||
| levelWorkers int // Number of "workers" that expect compactions to be in a disabled state | ||
| wg *sync.WaitGroup // waitgroup for active level compaction goroutines |
There was a problem hiding this comment.
I had to read the code pretty closely to understand why wg is kept as a field even though it's passed through some methods as arguments. The comment here or in enableLevelCompactions could probably explain it better.
jwilder
approved these changes
Jan 18, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been an elusive issue, but this should fix the data race seen occasionally during testing.