Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error for series file when no shards exist #9603

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Remove error for series file when no shards exist #9603

merged 1 commit into from
Mar 20, 2018

Conversation

benbjohnson
Copy link
Contributor

A nil iterator should be returned on an empty shard set.

@ghost ghost assigned benbjohnson Mar 20, 2018
@ghost ghost added the review label Mar 20, 2018
@benbjohnson benbjohnson added this to the 1.5.1 milestone Mar 20, 2018
e-dard
e-dard approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benbjohnson benbjohnson merged commit 1ae4b0c into 1.5 Mar 20, 2018
@ghost ghost removed the review label Mar 20, 2018
@benbjohnson benbjohnson mentioned this pull request Mar 21, 2018
Merged
@benbjohnson benbjohnson deleted the bj-check-shard-count-on-series-iterator branch April 20, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard e-dard approved these changes

@jwilder jwilder jwilder approved these changes

@stuartcarnie stuartcarnie Awaiting requested review from stuartcarnie

Assignees

@benbjohnson benbjohnson

Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@benbjohnson @jwilder @e-dard