Implement SHOW STATS FOR 'indexes' #9822
Merged
+74
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
During a run of megacheck the following issues were discovered: |
jacobmarble
requested review from
benbjohnson and
e-dard
and removed request for
benbjohnson
|
Working on the failing test. |
|
During a run of megacheck the following issues were discovered: |
benbjohnson
approved these changes
May 10, 2018
|
During a run of megacheck the following issues were discovered: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9766
This change adds
SHOW STATS FOR 'indexes'which returns an estimate of memory use of all indexes. Index memory use is not reported withSHOW STATSbecause it is a potentially expensive operation, and the implementation ofSHOW STATSis also triggered every 10s to populate the_internaldatabase.Tested by comparing the output of this new function to the heap pprof. Results are comparable, not perfect, but pprof doesn't hold absolute truth either.