Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow value filtering on SHOW TAG VALUES #9977

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Allow value filtering on SHOW TAG VALUES #9977

merged 1 commit into from
Jun 28, 2018

Conversation

benbjohnson
Copy link
Contributor

@benbjohnson benbjohnson commented Jun 15, 2018 •
edited
Loading

This pull request allows users to filter on the value field in the SHOW TAG VALUES command:

SHOW TAG VALUES WITH KEY = "mytag" WHERE "value" = 'myvalue'

Previously this command would return all values.

Fixes #9555

@benbjohnson benbjohnson self-assigned this Jun 15, 2018
@benbjohnson benbjohnson requested a review from e-dard June 15, 2018 14:43
@ghost ghost added the review label Jun 15, 2018
e-dard
e-dard suggested changes Jun 16, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a bit of test coverage? Maybe some examples on top of the existing ones in the tests package?

@benbjohnson benbjohnson force-pushed the bj-show-tag-values-value-filtering branch from 6925c3a to e28073c Compare June 19, 2018 14:18
@benbjohnson
Copy link
Contributor Author

@e-dard Added tests in e28073c.

@hercules-influx
Copy link
Collaborator

During a run of megacheck the following issues were discovered:

@benbjohnson
Copy link
Contributor Author

@e-dard Is this ok to merge?

@e-dard
Copy link
Contributor

e-dard commented Jun 26, 2018

@benbjohnson go fmt issue?

e-dard
e-dard approved these changes Jun 26, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 subject to CI

@benbjohnson
Allow value filtering on SHOW TAG VALUES
8be85c1 
This commit allows users to filter on the `value` field in the
`SHOW TAG VALUES` command:

	SHOW TAG VALUES WITH KEY = "mytag" WHERE "value" = 'myvalue'

Previously this command would return all values.
@benbjohnson benbjohnson force-pushed the bj-show-tag-values-value-filtering branch from e28073c to 8be85c1 Compare June 28, 2018 15:50
@hercules-influx
Copy link
Collaborator

During a run of megacheck the following issues were discovered:

@benbjohnson benbjohnson merged commit 7727a4a into master Jun 28, 2018
@benbjohnson benbjohnson deleted the bj-show-tag-values-value-filtering branch June 28, 2018 16:25
@ghost ghost removed the review label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard e-dard approved these changes

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbjohnson @hercules-influx @e-dard