fix(teams): make ChannelURL naming consistent (#2545)

* chore: ignore /vendor directory * fix(teams): rename channel_url to channel-url to match config
influxdata · May 10, 2021 · ebee9bf · ebee9bf
1 parent 1f2c956
commit ebee9bf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -22,3 +22,6 @@ kapacitor*.zip
 /kapacitord
 /tickfmt
 /tickdoc
+
+# Ignore go vendor directory
+/vendor
diff --git a/pipeline/alert.go b/pipeline/alert.go
@@ -2248,7 +2248,7 @@ type TeamsHandler struct {
 
 	// Teams channel webhook URL to post messages.
 	// If empty uses the URL from the configuration.
-	ChannelURL string `json:"channel_url"`
+	ChannelURL string `json:"channel-url"`
 }
 
 // Send the alert to ServiceNow.

diff --git a/server/server_test.go b/server/server_test.go
@@ -9400,7 +9400,7 @@ func TestServer_ListServiceTests(t *testing.T) {
 				Link: client.Link{Relation: client.Self, Href: "/kapacitor/v1/service-tests/teams"},
 				Name: "teams",
 				Options: client.ServiceTestOptions{
-					"channel_url": "",
+					"channel-url": "",
 					"alert_topic": "test kapacitor alert topic",
 					"alert_id":    "foo/bar/bat",
 					"message":     "test teams message",

diff --git a/services/teams/service.go b/services/teams/service.go
@@ -70,7 +70,7 @@ func (s *Service) StateChangesOnly() bool {
 }
 
 type testOptions struct {
-	ChannelURL string      `json:"channel_url"`
+	ChannelURL string      `json:"channel-url"`
 	AlertTopic string      `json:"alert_topic"`
 	AlertID    string      `json:"alert_id"`
 	Message    string      `json:"message"`