Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WARN log level to INFO #1668

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Change WARN log level to INFO #1668

merged 2 commits into from
Nov 9, 2017

Conversation

desa
Copy link
Contributor

@desa desa commented Nov 8, 2017

This PR removes the concept of a WARN log level and changes all WARN level logs to INFO level logs.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@ghost ghost assigned desa Nov 8, 2017
@ghost ghost added the in progress label Nov 8, 2017
@desa desa requested a review from nathanielc November 8, 2017 22:26
@desa desa force-pushed the md-remove-warn-logs branch 2 times, most recently from d44452e to 33ada85 Compare November 8, 2017 23:15
@desa
Copy link
Contributor Author

desa commented Nov 9, 2017

@nathanielc looks like this keeps failing on

--- FAIL: TestServer_RecordReplayStreamWithPost (1.20s)
	server_test.go:3529: failed to finish recording

Things seem to be passing for me locally.

@desa
Copy link
Contributor Author

desa commented Nov 9, 2017

Took about ~5-6 rebuilds but the tests finally passed.

@nathanielc
Copy link
Contributor

Yeah, its passing for me locally as well. We need to get that test fixed.

@nathanielc nathanielc merged commit 2f96356 into master Nov 9, 2017
nathanielc added a commit that referenced this pull request Nov 9, 2017
@ghost ghost removed the in progress label Nov 9, 2017
@nathanielc nathanielc deleted the md-remove-warn-logs branch November 9, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants