Add links to pagerduty2 alerts

[onlynone]

Required for all non-trivial PRs

• Rebased/mergable
• Tests pass
• CHANGELOG.md updated
• Sign CLA (if not already signed)

This feature allows one to do:

alert()
  .pagerDuty2()
    .link('http://some.example.com/here', 'here')
    .link('http://other.example.com/there', 'there')

To add a list of custom links to pagerduty alerts. They'll be put in the links field of the body sent to https://events.pagerduty.com/v2/enqueue as per the docs here: https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2. Both the URL and text fields are treated as templates so one can interpolate fields/tags/etc. The link text is optional and will default to the link url when missing.

[onlynone]

@stevebang @russorat @nathanielc @timhallinflux I'd love some feedback on this feature.

[onlynone]

It looks like all tests passed but the test just exited with a 1 exit code? I grepped through the output and I see 830 tests run, 829 tests passed, and 1 test skipped.

[onlynone]

@stevebang @russorat @nathanielc @timhallinflux Can someone take a look at this? Also, is there a way to trigger another test build run?

[onlynone]

@stevebang @russorat @nathanielc @timhallinflux I've merged master and made a tweak to the changelog which forced a new build which succeeded this time. Anything else I can do?

[rbetts]

Can you clarify how this fits with: #2081. Thanks for the contribution. Help me sort out what (if at all) overlaps and we will review this for K. 1.5.2.

[nathanielc]

LGTM, I have tested locally. I will also put up a PR to add one more test case.