Improve Kafka alert throughput #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-kafka-perf
branch
2 times, most recently
from
94b039f to
0450048
Compare
|
@stevebang This PR update the docs for the Kafka alert handler, can you incorporate these changes into the docs site? |
| cluster: c.cfg.ID, | ||
| topic: topic, | ||
| } | ||
| w.Open() |
There was a problem hiding this comment.
do we need a routine to cleanup and close all the writers at some point?
There was a problem hiding this comment.
Writers already had logic to close them. This change just creates the companion Open method since now the initialization is more complex than creating the type.
aanthony1243
approved these changes
Jun 29, 2018
nathanielc
added a commit
that referenced
this pull request
Jul 3, 2018
Improve Kafka alert throughput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the Async mode is used to write messages to Kafka. This mode allows for greater throughput at the cost of not blocking on the acknowledgment of the writes. As such new statistics are added for each configured kafka cluster and topic.