Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): use default transport consitently #2167

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Conversation

nathanielc
Copy link
Contributor

The http transport used in most places did not have sane defaults. This change consolidates creation of a new http transport.

These changes only effect outgoing HTTP connections from Kapacitor, which tend to be low volume.

@nathanielc
Copy link
Contributor Author

This PR should wait for #2154 to be merged and then update the one instance of using creating a transport there.

@nathanielc nathanielc requested review from desa and aanthony1243 March 7, 2019 00:08
Copy link
Contributor

@desa desa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@nathanielc nathanielc force-pushed the feat/http-transport branch from 3ae1ea1 to 537061e Compare March 11, 2019 18:59
@nathanielc nathanielc merged commit 55900e4 into master Mar 11, 2019
@nathanielc nathanielc deleted the feat/http-transport branch March 11, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants