Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the kafka library to set the timestamp correctly #2253

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Upgrade the kafka library to set the timestamp correctly #2253

merged 1 commit into from
Sep 20, 2019

Conversation

jsternberg
Copy link
Contributor

No description provided.

@jsternberg jsternberg requested a review from a team September 18, 2019 19:54
@ghost ghost requested review from affo and removed request for a team September 18, 2019 19:54
affo
affo reviewed Sep 19, 2019
View reviewed changes
Copy link
Contributor

@affo affo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an update to the kafka lib that causes cascading updates and additions to vendor?

Gosh, Gopkg.lock is unreadable.
Why is nothing changing in Gopkg.toml?

@jsternberg
Copy link
Contributor Author

It's because the Gopkg.toml just specifies constraints and Gopkg.lock locks the revisions. I updated the version of github.com/segmentio/kafka-go using dep ensure -update github.com/segmentio/kafka-go.

The Gopkg.lock may have changed because I used a different version of dep than was originally used. I couldn't identify the version and it may have been last generated with a specific revision between 0.4.1 and 0.5.0.

@jsternberg
Copy link
Contributor Author

I fixed the unit and integration tests and it also now checks that the timestamp is being set.

@jsternberg jsternberg requested a review from affo September 19, 2019 20:10
affo
affo approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@affo affo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

So, basically the previous version of kafka didn't use timestamps, and the updated one yes.

So you adapted the test server to account for those 👍

@jsternberg jsternberg merged commit 5d93d01 into master Sep 20, 2019
@jsternberg jsternberg deleted the kafka-upgrade branch September 20, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affo affo affo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @affo