Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit hook go vet correction #2286

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Pre-commit hook go vet correction #2286

merged 3 commits into from
Apr 27, 2020

Conversation

mattnotmitt
Copy link
Contributor

@mattnotmitt mattnotmitt commented Feb 9, 2020 •
edited
Loading

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Go has deprecated invoking the vet tool through the go tool command, which flags an error in the pre-commit hook. This is a slight correction to use the go vet invocation instead.

@docmerlin docmerlin self-assigned this Apr 22, 2020
@docmerlin docmerlin merged commit d33a331 into influxdata:master Apr 27, 2020
@docmerlin
Copy link
Contributor

@mattnotmitt Thanks for this. Sorry that it has taken so long to get to this!

@mattnotmitt mattnotmitt deleted the chore/fix-pre-commit-hook branch April 28, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@docmerlin docmerlin docmerlin approved these changes

@nathanielc nathanielc Awaiting requested review from nathanielc

Assignees

@docmerlin docmerlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattnotmitt @docmerlin