Feature: Discord Webhook Alert Handler

[mattnotmitt]

Required for all non-trivial PRs

• Rebased/mergable
• Tests pass
• CHANGELOG.md updated
• Sign CLA (if not already signed)

Added a Discord Channel Webhook alert handler.

TODO

• Add service/discord/discordtest
• Write documentation and contribute to https://github.com/influxdata/docs.influxdata.com
• Comment code in pipeline/alert.go

Screenshot of test notification in Discord client

[goller]

Awesome! I didn't to a complete review, but, here are a few changes to fix up.

[mattnotmitt]

Ha, sorry, thought I'd caught all of those, pushing now!

[mattnotmitt]

I'm also happy to add the required stuff to Chronograf, I'd just need a pointer to what needs updating!

[desa]

@mattnotmitt is this ready for another review?

[mattnotmitt]

@desa very nearly, there's an issue I'm experiencing with the timestamp boolean - I posted about it in the kapacitor channel in the influxdata community slack.

[desa]

@mattnotmitt can you link me to the issue?

[mattnotmitt]

I've pinged you in the thread but here's the text: I've been having some trouble with using a boolean in the HandlerConfig for a custom alert handler. If you look at my pr https://github.com/influxdata/kapacitor/pull/2287/files, the Timestamp is a boolean field configurable in both in the `kapacitor.conf` file and when the handler is called inline. Oddly, the value in the `kapacitor.conf` file is ignored always, and the only way i can decide whether the timestamp shows or not is if it is set in the tickscript. Could someone with knowledge of the arcane internals of the kapacitor config loading give me a hand? I'm sure i could figure it out myself but I'd appreciate some guidance.

…

On Fri, 27 Mar 2020, 16:37 Michael Desa, ***@***.***> wrote: @mattnotmitt <https://github.com/mattnotmitt> can you link me to the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQBM7RHIKQNPAKULAIH3RDRJTI4BANCNFSM4KSLJKJQ> .

[mattnotmitt]

@desa Ready for review whenever you're available.

[desa]

@mattnotmitt were you able to take a look at my suggestion in slack?

[mattnotmitt]

Yeah I looked and replied. There's no discernable difference between it being set to false and it just not being set. Decided to just take away the handler config and keep it in the conf file.

…

On Mon, 30 Mar 2020, 16:23 Michael Desa, ***@***.***> wrote: @mattnotmitt <https://github.com/mattnotmitt> were you able to take a look at my suggestion in slack? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQBM7TSSUUBBD2GI4UTL6TRKC2QPANCNFSM4KSLJKJQ> .

[desa]

Typically people use pointers to differentiate between the two. I think that should work.

[mattnotmitt]

I don't really know how to implement that (my go skills aren't that great) and the timestamp is so tiny that I find it unlikely that someone would need to hide it. If you need this to merge I might be able to do it in a few months but I need to knuckle down on some other work now, sorry.

…

On Mon, 30 Mar 2020, 17:11 Michael Desa, ***@***.***> wrote: Typically people use pointers to differentiate between the two. I think that should work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQBM7RFCJWK6ME3CDIPCSLRKDACDANCNFSM4KSLJKJQ> .

[desa]

@mattnotmitt just reaching out with regards to

I'm also happy to add the required stuff to Chronograf, I'd just need a pointer to what needs updating!

Is this something that you'd still be interested in doing? I'd be happy to offer an outline of the steps involved.

[mattnotmitt]

@mattnotmitt just reaching out with regards to
...
Is this something that you'd still be interested in doing? I'd be happy to offer an outline of the steps involved.

Hi @desa, yeah I'd still be happy to work on that!
Also if you know anyone on the influx v2 team who could give me a guide to reimplement this one for that, I'd be happy to do that too!

[desa]

@mattnotmitt Awesome. For 2.0 of InfluxDB, you're going to want to take a look at the code in https://github.com/influxdata/flux/blob/8a6ee0356c0837db0ace34cb7a2578be600874d3/stdlib/pagerduty/pagerduty.flux, https://github.com/influxdata/influxdb/tree/master/notification/endpoint, and https://github.com/influxdata/influxdb/tree/master/notification/rule. This part of the 2.0 codebase is a bit rough with a fair amount of repeated logic.

For 1.x Chronograf, you'll want to start looking in https://github.com/influxdata/chronograf/blob/2dadcaf8dcb6a6733e027e1d9205f3688b81b62d/ui/src/types/kapacitor.ts and https://github.com/influxdata/chronograf/blob/9d8a49ba0ef8131cdce22d73718859f55f434db2/ui/src/kapacitor/components/handlers/index.js.

[docmerlin]

APPROVED!