Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS1.3 support #2322

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Add TLS1.3 support #2322

merged 2 commits into from
Apr 21, 2020

Conversation

docmerlin
Copy link
Contributor

@docmerlin docmerlin commented Apr 20, 2020 •
edited
Loading

This adds support for TLS 1.3

gunnaraasen
gunnaraasen approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@gunnaraasen gunnaraasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat orthogonal though: I'm not sure which version of Go we build off of right now, but we may also want to make sure we're building off the most recent patch release of 1.13 (or 1.14). Otherwise this LGTM!

@docmerlin
Copy link
Contributor Author

@gunnaraasen we can't build off the most recent 1.14.2 till we remove support for SSL 3.0, but I agree.

@docmerlin docmerlin merged commit 28b69c1 into master Apr 21, 2020
@docmerlin docmerlin deleted the feat/tls13 branch April 21, 2020 21:13
@docmerlin docmerlin mentioned this pull request Apr 21, 2020
Closed
@sranka sranka mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnaraasen gunnaraasen gunnaraasen approved these changes

@nathanielc nathanielc Awaiting requested review from nathanielc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docmerlin @gunnaraasen