Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: .Details should be avaliable inside AlertTemplates #2395

Merged
merged 2 commits into from
Sep 3, 2020
Merged

fix: .Details should be avaliable inside AlertTemplates #2395

merged 2 commits into from
Sep 3, 2020

Conversation

docmerlin
Copy link
Contributor

@docmerlin docmerlin commented Sep 2, 2020 •
edited
Loading

This adds .Details to AlertTemplates, where it should have been.

@psteinbachs psteinbachs added this to the 1.5.7 milestone Sep 2, 2020
@docmerlin docmerlin requested a review from ayang64 September 3, 2020 14:57
ayang64
ayang64 approved these changes Sep 3, 2020
View reviewed changes
Copy link

@ayang64 ayang64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docmerlin docmerlin merged commit 4d278f6 into master Sep 3, 2020
@docmerlin docmerlin deleted the fix/details-in-template branch September 3, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayang64 ayang64 ayang64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.7
Development

Successfully merging this pull request may close these issues.
3 participants
@docmerlin @ayang64 @psteinbachs