Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use kapacitor alert details as opsgenie description text #2409

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

JamesClonk
Copy link
Contributor

This is a breaking change in the OpsGenie plugin behaviour of Kapacitor. The modification will use alert/event state details as description when opening OpsGenie alerts instead. This allows much more descriptive alerts in OpsGenie. Alert details in OpsGenie are still filled with the same key/values as before.

The current behaviour of simply encoding the event details as description is imho not very useful as a value for an OpsGenie alert description, Kapacitor alert details can provide much more information and are more in line with OpsGenie alert descriptions.

Would such a change make sense, or is it too breaking in current behaviour?

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@psteinbachs psteinbachs requested a review from docmerlin October 1, 2020 14:58
@docmerlin
Copy link
Contributor

@JamesClonk With this kind of breaking change, it would be a good idea to add a method to the node that tells it to do this behavior, so the new behavior is optional.

@JamesClonk
Copy link
Contributor Author

@docmerlin Makes sense, I'll have a look at it.

Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a method on the node so you can select the breaking behavior while defaulting to current behavior.

@JamesClonk
Copy link
Contributor Author

@docmerlin I'm trying to figure out how to do that exactly. Is it enough to just add a field to the Config struct, does that automatically also add a method on the OpsGenie event handler node (It seems that way but I'm not 100% sure)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants