fix: add barrier handling to flatten #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
approved these changes
Feb 5, 2021
timhallinflux
added a commit
that referenced
this pull request
Apr 1, 2021
fix link for issue #2474 -- was pointing to 2491
Merged
docmerlin
added a commit
that referenced
this pull request
Apr 2, 2021
* Update CHANGELOG.md fix link for issue #2474 -- was pointing to 2491 * chore: Update Changelog Co-authored-by: J. Emrys Landivar <landivar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds barrier handling to flatten, so that barriers actually cause flatten to emit its points.
Unfortunately, because of the timing stuff here, its quite hard to test this in an automated way. I've tested it manually, and will think about how to test these in a more automated way with the PR for join's barrier handling.