-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance metrics to tasks and node #248
Conversation
d60dd66
to
8db72c4
Compare
Hi @nathanielc , Instead of:
Do something like this:
This way the DOT graph will be much easier to parse and show in a UI for example and it's valid syntax (DOT Attributes) |
Both locally and via g.gravizo.com those attributes are ignored. They need to be ![Alt text](http://g.gravizo.com/g? vs ![Alt text](http://g.gravizo.com/g? |
add throughput to task
b862704
to
0aab1d7
Compare
You want it to be valid for view and for parsing, so let's merge our solutions: both label and attributes. |
@yosiat I think you are right, but the labels will clutter it up too much. I think by default I will do it your way as that is more human readable which is the common use case. And then a flag can be specified to use labels instead so it renders correctly. Thoughts? I don't like the complexity of something that should be so simple :( Maybe there is another graph language that is easier to read and still renders well? I'll take a look around. |
0aab1d7
to
0a68197
Compare
Looking through all of these https://gephi.org/users/supported-graph-formats/ I still like DOT the best as it reads well. For now I guess we can add the flag and revisit later if it becomes cumbersome to set the flag when its needed. |
1b35c79
to
7bb182a
Compare
@nathanielc I agree with this option of flags. By the way - is is possible to see all that metrics in InfluxDB & Chronograf? Self answeing myself here, from the release notes:
|
7bb182a
to
e88b6c4
Compare
Add performance metrics to tasks and nodes
Fixes #215
This PR exposes two metrics to the user about throughput and execution time:
These values are exposed via the Kapacitor
show
command and in the internal statistics Kapacitor emits. As a result it is possible to graph throughput and execution times or other stats a node exposes.