-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory leaks. #2489
fix: memory leaks. #2489
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
//lint:file-ignore U1000 this is generated code | ||
package kapacitor | ||
|
||
{{with $types := .}}{{range $k := $types}} | ||
|
||
// {{ $k }}CircularQueue defines a circular queue, always use the contructor to create one. | ||
type {{ $k }}CircularQueue struct { | ||
data []{{ $k }} | ||
head int | ||
tail int | ||
l int | ||
} | ||
|
||
|
||
// {{ if eq (substr 0 1 $k ) (substr 0 1 $k | upper) -}} New {{- else -}} new {{- end -}} | ||
{{- substr 0 1 $k | upper -}}{{- substr 1 (len $k) $k -}} constructs a Circular Queue | ||
// with a given buffer buf. It is ok for buf to be nil. | ||
func {{ if eq (substr 0 1 $k ) (substr 0 1 $k | upper) -}} New {{- else -}} new {{- end -}} | ||
{{- substr 0 1 $k | upper -}}{{- substr 1 (len $k) $k -}} CircularQueue(buf ...{{ $k }}) *{{ $k }}CircularQueue { | ||
// if we have a useless buffer, make one that is at least useful | ||
if cap(buf) < 4{ | ||
buf = append(make([]{{ $k }}, 0, 4), buf...) | ||
} | ||
return &{{ $k }}CircularQueue{ | ||
data: buf[:cap(buf)], | ||
tail: len(buf), // tail is here we insert | ||
l: len(buf), | ||
} | ||
} | ||
|
||
// Enqueue adds an item to the queue. | ||
func (q * {{- $k -}} CircularQueue) Enqueue(v {{ $k }}) { | ||
// if full we must grow and insert together. This is an expensive op | ||
if cap(q.data) > q.l {// no need to grow | ||
if q.tail == len(q.data){ | ||
q.tail = 0 | ||
} | ||
q.data[q.tail] = v | ||
}else{ // we need to grow | ||
buf := make([]{{ $k }}, cap(q.data)*2) | ||
if q.head < q.tail{ | ||
copy(buf, q.data[q.head:q.tail]) | ||
} else { | ||
partialWriteLen := copy(buf, q.data[q.head:]) | ||
copy(buf[partialWriteLen:], q.data[:q.tail]) | ||
} | ||
q.head = 0 | ||
q.tail = cap(q.data) | ||
buf[q.tail] = v | ||
q.data = buf | ||
} | ||
q.l++ | ||
q.tail++ | ||
return | ||
} | ||
|
||
// Dequeue removes n items from the queue. If n is longer than the number of the items in the queue it will clear them all out. | ||
func (q *{{ $k }}CircularQueue) Dequeue(n int) { | ||
if n<=0{ | ||
return | ||
} | ||
if q.l <= n{ | ||
n = q.l | ||
} | ||
ni:=n | ||
var fill {{ $k }} | ||
if q.head>q.tail{ | ||
for i:=q.head;i<len(q.data)&&ni>0;i++{ | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
for i:=0;i<q.tail&&ni>0;i++{ | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} else { | ||
for i:=q.head;i<q.tail&&ni>0;i++{ | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} | ||
q.head+=n | ||
if q.head>len(q.data){ | ||
q.head -= len(q.data) | ||
} | ||
q.l-=n | ||
if q.l==0{ | ||
q.head = 0 | ||
q.tail = 0 | ||
} | ||
return | ||
} | ||
|
||
// Peek peeks i ahead of the current head of queue. It should be used in conjunction with .Len() to prevent a panic. | ||
func (q *{{ $k }}CircularQueue) Peek(i int) {{ $k }} { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This might be better named There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I will keep it this same. |
||
if i<0 || i>= q.l{ | ||
panic("peek index is out of bounds") | ||
} | ||
p := q.head + i | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we bounds check to make sure we don't get garbage? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's intended to be used in conjuction with .Len to avoid that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok added the bounds check. |
||
|
||
if p >= len(q.data) { | ||
p-=len(q.data) | ||
} | ||
return q.data[p] | ||
} | ||
|
||
|
||
// Len returns the current number of items in the queue. | ||
func (q *{{ $k }}CircularQueue) Len() int { | ||
return q.l | ||
} | ||
|
||
{{end}} | ||
{{end}} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,214 @@ | ||
// Generated by tmpl | ||
lesam marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// https://github.com/benbjohnson/tmpl | ||
// | ||
// DO NOT EDIT! | ||
// Source: circularqueue.gen.go.tmpl | ||
|
||
//lint:file-ignore U1000 this is generated code | ||
package kapacitor | ||
|
||
// circularIntCircularQueue defines a circular queue, always use the contructor to create one. | ||
type circularIntCircularQueue struct { | ||
data []circularInt | ||
head int | ||
tail int | ||
l int | ||
} | ||
|
||
// newCircularIntconstructs a Circular Queue | ||
// with a given buffer buf. It is ok for buf to be nil. | ||
func newCircularIntCircularQueue(buf ...circularInt) *circularIntCircularQueue { | ||
// if we have a useless buffer, make one that is at least useful | ||
if cap(buf) < 4 { | ||
buf = append(make([]circularInt, 0, 4), buf...) | ||
} | ||
return &circularIntCircularQueue{ | ||
data: buf[:cap(buf)], | ||
tail: len(buf), // tail is here we insert | ||
l: len(buf), | ||
} | ||
} | ||
|
||
// Enqueue adds an item to the queue. | ||
func (q *circularIntCircularQueue) Enqueue(v circularInt) { | ||
// if full we must grow and insert together. This is an expensive op | ||
if cap(q.data) > q.l { // no need to grow | ||
if q.tail == len(q.data) { | ||
q.tail = 0 | ||
} | ||
q.data[q.tail] = v | ||
} else { // we need to grow | ||
buf := make([]circularInt, cap(q.data)*2) | ||
if q.head < q.tail { | ||
copy(buf, q.data[q.head:q.tail]) | ||
} else { | ||
partialWriteLen := copy(buf, q.data[q.head:]) | ||
copy(buf[partialWriteLen:], q.data[:q.tail]) | ||
} | ||
q.head = 0 | ||
q.tail = cap(q.data) | ||
buf[q.tail] = v | ||
q.data = buf | ||
} | ||
q.l++ | ||
q.tail++ | ||
return | ||
} | ||
|
||
// Dequeue removes n items from the queue. If n is longer than the number of the items in the queue it will clear them all out. | ||
func (q *circularIntCircularQueue) Dequeue(n int) { | ||
if n <= 0 { | ||
return | ||
} | ||
if q.l <= n { | ||
n = q.l | ||
} | ||
ni := n | ||
var fill circularInt | ||
if q.head > q.tail { | ||
for i := q.head; i < len(q.data) && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
for i := 0; i < q.tail && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} else { | ||
for i := q.head; i < q.tail && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} | ||
q.head += n | ||
if q.head > len(q.data) { | ||
q.head -= len(q.data) | ||
} | ||
q.l -= n | ||
if q.l == 0 { | ||
q.head = 0 | ||
q.tail = 0 | ||
} | ||
return | ||
} | ||
|
||
// Peek peeks i ahead of the current head of queue. It should be used in conjunction with .Len() to prevent a panic. | ||
func (q *circularIntCircularQueue) Peek(i int) circularInt { | ||
if i < 0 || i >= q.l { | ||
panic("peek index is out of bounds") | ||
} | ||
p := q.head + i | ||
|
||
if p >= len(q.data) { | ||
p -= len(q.data) | ||
} | ||
return q.data[p] | ||
} | ||
|
||
// Len returns the current number of items in the queue. | ||
func (q *circularIntCircularQueue) Len() int { | ||
return q.l | ||
} | ||
|
||
// circularIntPtrCircularQueue defines a circular queue, always use the contructor to create one. | ||
type circularIntPtrCircularQueue struct { | ||
data []circularIntPtr | ||
head int | ||
tail int | ||
l int | ||
} | ||
|
||
// newCircularIntPtrconstructs a Circular Queue | ||
// with a given buffer buf. It is ok for buf to be nil. | ||
func newCircularIntPtrCircularQueue(buf ...circularIntPtr) *circularIntPtrCircularQueue { | ||
// if we have a useless buffer, make one that is at least useful | ||
if cap(buf) < 4 { | ||
buf = append(make([]circularIntPtr, 0, 4), buf...) | ||
} | ||
return &circularIntPtrCircularQueue{ | ||
data: buf[:cap(buf)], | ||
tail: len(buf), // tail is here we insert | ||
l: len(buf), | ||
} | ||
} | ||
|
||
// Enqueue adds an item to the queue. | ||
func (q *circularIntPtrCircularQueue) Enqueue(v circularIntPtr) { | ||
// if full we must grow and insert together. This is an expensive op | ||
if cap(q.data) > q.l { // no need to grow | ||
if q.tail == len(q.data) { | ||
q.tail = 0 | ||
} | ||
q.data[q.tail] = v | ||
} else { // we need to grow | ||
buf := make([]circularIntPtr, cap(q.data)*2) | ||
if q.head < q.tail { | ||
copy(buf, q.data[q.head:q.tail]) | ||
} else { | ||
partialWriteLen := copy(buf, q.data[q.head:]) | ||
copy(buf[partialWriteLen:], q.data[:q.tail]) | ||
} | ||
q.head = 0 | ||
q.tail = cap(q.data) | ||
buf[q.tail] = v | ||
q.data = buf | ||
} | ||
q.l++ | ||
q.tail++ | ||
return | ||
} | ||
|
||
// Dequeue removes n items from the queue. If n is longer than the number of the items in the queue it will clear them all out. | ||
func (q *circularIntPtrCircularQueue) Dequeue(n int) { | ||
if n <= 0 { | ||
return | ||
} | ||
if q.l <= n { | ||
n = q.l | ||
} | ||
ni := n | ||
var fill circularIntPtr | ||
if q.head > q.tail { | ||
for i := q.head; i < len(q.data) && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
for i := 0; i < q.tail && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} else { | ||
for i := q.head; i < q.tail && ni > 0; i++ { | ||
q.data[i] = fill | ||
ni-- | ||
} | ||
} | ||
q.head += n | ||
if q.head > len(q.data) { | ||
q.head -= len(q.data) | ||
} | ||
q.l -= n | ||
if q.l == 0 { | ||
q.head = 0 | ||
q.tail = 0 | ||
} | ||
return | ||
} | ||
|
||
// Peek peeks i ahead of the current head of queue. It should be used in conjunction with .Len() to prevent a panic. | ||
func (q *circularIntPtrCircularQueue) Peek(i int) circularIntPtr { | ||
if i < 0 || i >= q.l { | ||
panic("peek index is out of bounds") | ||
} | ||
p := q.head + i | ||
|
||
if p >= len(q.data) { | ||
p -= len(q.data) | ||
} | ||
return q.data[p] | ||
} | ||
|
||
// Len returns the current number of items in the queue. | ||
func (q *circularIntPtrCircularQueue) Len() int { | ||
return q.l | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invariant:
tail = (head + l) % len(data)
right? Is it worth keeping it separately?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, its mostly so we don't have to do a mod over and over again, it isn't strictly necessary.