feat: flux tasks skeleton in Kapacitor #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including: - configuration - analytical store writes to remote influxdb - zap logging adapter
lesam
changed the title
lesam
changed the title
lesam
commented
May 11, 2021
| logger *zap.Logger | ||
| } | ||
|
|
||
| func (d *DummyQueryService) Query(ctx context.Context, compiler flux.Compiler) (flux.ResultIterator, error) { |
There was a problem hiding this comment.
Note that this does not yet actually run flux tasks, since we are using this dummy query service.
docmerlin
reviewed
May 11, 2021
| return r.close() | ||
| } | ||
|
|
||
| var _ io.ReadCloser = readClose{} |
There was a problem hiding this comment.
I really like this as a way of telling the compiler to make sure that a type satisfies an interface.
There was a problem hiding this comment.
GoLand even lets you right-click this line to add method stubs if you haven't implemented them yet.
| @@ -29,7 +29,7 @@ DOCKER_SAVE_DIR=${DOCKER_SAVE_DIR-$HOME/docker} | |||
| # Set default parallelism | |||
| PARALLELISM=${PARALLELISM-1} | |||
| # Set default timeout | |||
| TIMEOUT=${TIMEOUT-480s} | |||
| TIMEOUT=${TIMEOUT-1000s} | |||
docmerlin
approved these changes
May 12, 2021
lesam
commented
Jun 15, 2021
| return nil, 0, err | ||
| } | ||
|
|
||
| if filter.After != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2534
Required for all non-trivial PRs