Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigpanda): fields of alerting data point are serialized to proper types #2592

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 13, 2021

Closes https://github.com/influxdata/EAR/issues/2365

This PR changes how are serialized fields of alerting data into BigPanda payload - use original type of field instead mapping a field value to string.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@bednar bednar changed the title fix: fields of alerting data point are serialized to proper types fix(bigpanda): fields of alerting data point are serialized to proper types Jul 13, 2021
@bednar bednar requested a review from rhajek July 13, 2021 08:26
@bednar bednar marked this pull request as ready for review July 13, 2021 08:26
@idclark
Copy link

idclark commented Jul 13, 2021

@bednar is there an instance of BigPanda I can use to test API calls against this build before handing it off to the customer?

@timhallinflux timhallinflux requested a review from docmerlin July 14, 2021 17:00
Copy link
Contributor

@docmerlin docmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docmerlin docmerlin merged commit df99b44 into master Jul 15, 2021
@docmerlin docmerlin deleted the fix/bigpanda_json_serialization branch July 15, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants