feat(config): Env var config can now add new items #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for example: adding new headers to httpposts via environmental variables
lesam
approved these changes
Nov 19, 2021
| @@ -2,6 +2,57 @@ module github.com/influxdata/kapacitor | |||
|
|
|||
| go 1.17 | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
What happened here? Non-blocking, just weird.
There was a problem hiding this comment.
go mod tidy the new version sorts differently, and maintains sorting.
| @@ -640,8 +638,28 @@ func (c *Config) applyEnvOverridesToStruct(prefix string, s reflect.Value) error | |||
| } | |||
| } | |||
| } else if f.Kind() == reflect.Map { | |||
| for _, k := range f.MapKeys() { | |||
| if err := c.applyEnvOverridesToMap(fmt.Sprintf("%s_%v", key, k), fieldName, f, k, f.MapIndex(k)); err != nil { | |||
| keys := map[string]reflect.Value{} | |||
There was a problem hiding this comment.
Is this only for kapacitor.conf ?
There was a problem hiding this comment.
Yes, and environmental variable config of kap.
|
@docmerlin does this close: #2280 ? |
|
@timhallinflux yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for example: adding new headers to httpposts via
environmental variables