Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka): update sarama for https://github.com/Shopify/sarama/issu… #2679

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix(kafka): update sarama for https://github.com/Shopify/sarama/issu… #2679

merged 1 commit into from
Mar 10, 2022

Conversation

docmerlin
Copy link
Contributor

Shopify has withdrawn sarama 1v.31.0 because of IBM/sarama#2129
This upgrades Sarama to 1.32.0

danatinflux
danatinflux approved these changes Mar 10, 2022
View reviewed changes
Copy link

@danatinflux danatinflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Emrys says it's just a version update.

davidby-influx
davidby-influx approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@docmerlin docmerlin merged commit 1959476 into master Mar 10, 2022
@docmerlin docmerlin deleted the updateSarama branch March 10, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

@danatinflux danatinflux danatinflux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@docmerlin @danatinflux @davidby-influx