Add a validate phase that allows more validation at definition time #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2016
Closed
jonseymour
force-pushed
the
jss-438-add-validate-phase
branch
2 times, most recently
from
7e3ca5e
to
0f02f80
Compare
jonseymour
added a commit
to jonseymour/kapacitor
that referenced
this pull request
Apr 9, 2016
…cycle. It is better if we can detect and report configuration errors of task pipeline early, during task definition, rather than deferring such checks to runtime (when this is possible). To support such checks, we add a Validate() error method to the pipeline.Node() interface which gives pipeline nodes a chance to validate their configuration. Any pipeline containing nodes that do not pass these test cannot be saved. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
jonseymour
added a commit
to jonseymour/kapacitor
that referenced
this pull request
Apr 9, 2016
…finition time. Assuming the acceptance of PR influxdata#443, some validations previously performed at runtime can now be performed at definition time. The existing validations are moved into the pipeline.JoinNode type. The validations are extended to resolve the panic reported in issue influxdata#331. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
|
@jonseymour I like this change. The only part that I don't like is that now that all specific |
…cycle. It is better if we can detect and report configuration errors of task pipeline early, during task definition, rather than deferring such checks to runtime (when this is possible). To support such checks, we add a Validate() error method to the pipeline.Node() interface which gives pipeline nodes a chance to validate their configuration. Any pipeline containing nodes that do not pass these test cannot be saved. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
jonseymour
force-pushed
the
jss-438-add-validate-phase
branch
from
0f02f80
to
9b88fa3
Compare
jonseymour
added a commit
to jonseymour/kapacitor
that referenced
this pull request
Apr 13, 2016
…finition time. Assuming the acceptance of PR influxdata#443, some validations previously performed at runtime can now be performed at definition time. The existing validations are moved into the pipeline.JoinNode type. The validations are extended to resolve the panic reported in issue influxdata#331. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
|
I'll have to rebase again tomorrow - dead tired now. |
nathanielc
pushed a commit
that referenced
this pull request
May 4, 2016
…ime. Assuming the acceptance of PR #443, some validations previously performed at runtime can now be performed at definition time. The existing validations are moved into the pipeline.JoinNode type. The validations are extended to resolve the panic reported in issue #331. Signed-off-by: Jon Seymour <jon@wildducktheories.com>
nathanielc
pushed a commit
that referenced
this pull request
May 5, 2016
* PR #431: Move some join node validations from runtime to definition time. Assuming the acceptance of PR #443, some validations previously performed at runtime can now be performed at definition time. The existing validations are moved into the pipeline.JoinNode type. The validations are extended to resolve the panic reported in issue #331. Signed-off-by: Jon Seymour <jon@wildducktheories.com> * CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, more validation can be pushed from runtime to definition time.
See the current implementation of #431 for an example of how it is used.
Signed-off-by: Jon Seymour jon@wildducktheories.com