Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support float,integer,string and boolean #524

Merged
merged 5 commits into from
May 18, 2016
Merged

Support float,integer,string and boolean #524

merged 5 commits into from
May 18, 2016

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented May 6, 2016

Fixes #500 #495 #501

This was way easier than expected. I also did a check for all uses of float64 to make sure a field type wasn't assumed to be a float64.

TODO:

  • Enable EvalNode to return any of these types.

@yosiat
Copy link
Contributor

yosiat commented May 7, 2016

@nathanielc What do you mean by "Enable EvalNode to return any of these types.", we are supporting "EvalFloat", "EvalString" and etc.

@nathanielc
Copy link
Contributor Author

Yes 👍. I am waiting till #496 is merged though so we don't conflict.

On Sat, May 7, 2016, 1:51 AM Yosi Attias notifications@github.com wrote:

@nathanielc https://github.com/nathanielc What do you mean by "Enable
EvalNode to return any of these types.", we are supporting "EvalFloat",
"EvalString" and etc.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#524 (comment)

Nathaniel Cook
Kapacitor Lead
https://influxdata.com

@yosiat
Copy link
Contributor

yosiat commented May 7, 2016

@nathanielc ok, I thought there is something in stateful that doesn't support those types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants