Adding "if" function to tick #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func (*ifFunc) Call(args ...interface{}) (interface{}, error) { | ||
| if len(args) != 3 { | ||
| return nil, errors.New("if expects exactly three argument") |
There was a problem hiding this comment.
nit: Can you change argument to arguments?
|
@yosiat Looks great! A few small questions but overall this looks ready to go. |
yosiat
force-pushed
the
if-funciton
branch
2 times, most recently
from
49f14d4
to
f1f90d6
Compare
|
@nathanielc fixed everything 👍 |
| } | ||
|
|
||
| if reflect.TypeOf(args[1]) != reflect.TypeOf(args[2]) { | ||
| return nil, fmt.Errorf("Multiple return types isn't supported - second argument is %T and third argument is %T", args[1], args[2]) |
There was a problem hiding this comment.
nit:
I think this would read better if it read: Different return types are not supported - ...
| // multiple types | ||
| { | ||
| args: []interface{}{false, 1, "1"}, | ||
| err: errors.New("Multiple return types isn't supported - second argument is int and third argument is string"), |
There was a problem hiding this comment.
Tests are failing on this error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
Fixes #741