Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken deadman extra expressions #753

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fix broken deadman extra expressions #753

merged 1 commit into from
Jul 25, 2016

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented Jul 25, 2016

Fixes #718

We need to add tests for this but its not easy until the deadman can have its own clock. I'll create an issue to track this. #754

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@nathanielc nathanielc merged commit aa28035 into master Jul 25, 2016
@nathanielc nathanielc deleted the nc-issue#718 branch July 25, 2016 21:59
@gargooza
Copy link

Just to confirm, will this fix this error?
<30> Jul 25 18:15:07.106552 -04:00 kapacitord: [aCSE:alert5] 2016/07/25 18:15:07 E! error evaluating expression: Failed to handle 1 argument: name "time" is undefined. Names in scope: emitted

@nathanielc
Copy link
Contributor Author

Yes.

FWIW the cause of the error was the the LambdaNode itself was being appended to the alert condition instead of the expressions contained in the LambdaNode. Essentially doing this:

|alert()
   .crit(lambda: "emitted" < threshold AND lambda: hour("time") >= 20)

Which is clearly wrong, and confused the evaluation of the crit expression.

@bowdenandrew
Copy link

Thanks Nathaniel,

That definitely fixed the bug that I was seeing, I'll work up some more robust samples and if I have any further problems I'll let you know.

Thanks so much for making this code change.

Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants