This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
feat: path handling UX improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 4, 2022
| assert_eq!(Path::parse("/").unwrap().as_ref(), ""); | ||
| assert_eq!(Path::parse("").unwrap().as_ref(), ""); | ||
|
|
||
| let err = Path::parse("//").unwrap_err(); |
| @@ -214,6 +271,18 @@ where | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn filesystem_path_to_url(path: impl AsRef<std::path::Path>) -> Result<Url, Error> { | |||
There was a problem hiding this comment.
Perhaps a docstring explaining what this does would be useful as well
src/path/mod.rs
Outdated
| /// Convert a filesystem path to a [`Path`] relative to the provided base | ||
| /// | ||
| /// This will return an error if the path does not exist, contains illegal | ||
| /// character sequences as defined by [`Path::parse`], or does not start |
There was a problem hiding this comment.
I found "provided prefix" confusing as I didn't know what it was referring to. It seems to mean that the path must be prefixed by the the path in the base URL, if specified
There was a problem hiding this comment.
Oh sorry, I renamed the parameters and forgot to update the docstring
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of things came up whilst implementing apache/datafusion#2677 that would make life easier.
Path::parse("/")would return an errorstd::path::Pathtoobject_store::path::PathforLocalFileSystemThis PR addresses these