Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when run with default-spec.toml #1

Closed
kavirajk opened this issue Jun 23, 2024 · 0 comments · Fixed by #2
Closed

Panic when run with default-spec.toml #1

kavirajk opened this issue Jun 23, 2024 · 0 comments · Fixed by #2

Comments

@kavirajk
Copy link
Contributor

Steps to reproduce

  1. cargo build or cargo build --release
  2. cargo run or cargo run --release or ./target/release/parquet-gen or ./target/release/parquet-gen -s default-spec.toml

It panics with following error.

parse spec file: Error { inner: Error { inner: TomlError { message: "invalid inline table\nexpected `}`"

Problem.

I think the issue is with default-spec.toml. Particularly bloom_filter config.

# write with a bloom filter on this column
bloom_filter = {
  fpp = 0.1,
  ndv = 100000
}

Looks like we cannot use multi-line as show above. If I change it to following single-line, then it's able to parse default-spec.toml just fine.

# write with a bloom filter on this column
bloom_filter = { fpp = 0.1, ndv = 100000 }

Potential solution

Change bloom_filter config used in default-spec.toml to use single-line inline table like explained above.

Reference

  1. Similar issue with cargo.toml (not supporting multi-line inline table)
  2. Upstream issue of toml-rs (dependency used in this tool) still doesn't support TOML 1.1 spec which added support for multi-line inline table.
kavirajk added a commit to kavirajk/parquet-bloom-filter-analysis that referenced this issue Jun 23, 2024
fixes: influxdata#1

Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant