-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inputs.gnmi with dynamic tagging won't work #11778
Comments
@madd2008 sorry to hear you are having issues. What is your output supposed to look like? What was the last version where this was working? The most recent bug fix for |
@MyaLongmire ifcounters should contain a tag containing interface name based on this
And it doesn't do it anymore. |
I've downloaded and installed v1.23.1 [2022-07-05] and it works perfectly fine |
and btw this that could have solved the issue. Will try in a day or so. |
@bewing is there something that was missed or an obvious change required with this issue? |
I unfortunately do not have any access to any Juniper MX hardware to test at this time -- is it possible to reproduce this issue with a vMX instance? I can probably work on getting access to a vMX image file. |
It appears the doc change was reverted by #11489. I do not know the backstory there |
Yes, I believe so. Any Juniper device/VM(with the same Junos version) should provide a similar outcome. |
I believe any juniper device/VM should provide the same results. The closer
you can get to 19.4 version the better (for my use case). But it should not
be Junos version (this time) in my opinion.
…On Fri, Sep 30, 2022, 11:31 bewing ***@***.***> wrote:
I unfortunately do not have any access to any Juniper MX hardware to test
at this time -- is it possible to reproduce this issue with a vMX instance?
I can probably work on getting access to a vMX image file.
—
Reply to this email directly, view it on GitHub
<#11778 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6F3RY2BUVDPMMKRNEBPUDWA4PYVANCNFSM6AAAAAAQH6SUCY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
i am on the same team as OP. i have taken over this effort. I tried the new config discussed above, with a current version of telegraf (1.24.4-1) and it didn't work...population of the "description" field didn't happen in any of the messages. below are example configs and messages. like OP said, we don't think this is a problem specific to some junos version. just try it on whatever you have :-) CONFIG USED (telegraf-1.23.1-1)
GOOD OUTPUT (influx format; newlines inserted for readability):
CONFIG USED (telegraf-1.24.4-1)
BAD OUTPUT (influx format; newlines inserted for readability):
|
@srebhan thank you for looking into this. We have done the needful and noted that the problem persists with the updated binary. But we gathered the requested output. Please find it attached. |
@srebhan i also noticed that, in the tarball i downloaded for 1.26.0, the etc/telegraf/telegraf.conf still references the "tag_only" config for gnmi. i am not sure how this file relates to files that did change in the PR, like README.md and sample.conf. Those changed files are not present in the tarball. |
Confirming that I'm seeing this issue as well and that you've seen my logs on Slack. I'm okay with using the version pre-PR breakage but hopefully this gets resolved. Maybe roll back that PR? |
I reviewed and merged a PR to update some docs. Looks like it was tagged to fix this issue and per a previous comment it doesn't look like it actually fixed this one. @srebhan thoughts? |
@cjonesdialpad and @madd2008 please test the binary in #12512 and let me know if that fixes the issue! |
i downloaded the binary with the 3 additional commits from 18 jan 12:15...still broken for me. i have attached the log. i am still using the old-style config with "tag_only". |
The latest build in PR #12512 has successfully fixed both the old |
The latest build in PR #12512 has successfully fixed the old tag_only syntax for me. HOWEVER i cannot get the new "tag_subscription" syntax to work. I am configuring exactly as described in this link: https://github.com/influxdata/telegraf/tree/master/plugins/inputs/gnmi this is my config:
|
This is what I'm using successfully:
|
THANKS @cjonesdialpad ... i adjusted my config and it works!
@srebhan , @powersj , i am satisfied with this fix...thanks very much! when will it be released into the repos? :-) |
@clsmyth the change I had to make is massive, so I maybe need to break-up the PR into smaller, more digestible ones. We are working on getting this approved and merged, but it might be v1.26. Until then you can use the binary built in the PR... |
@srebhan that's OK...we have telegraf-1.23.1-1 pinned in our server. Having an out-of-date version installed is not causing us any trouble...yet :-) If 1.26 becomes the target version for this fix, could you perhaps share a rough estimate of what that timeline would look like for that release, please? A month? 2 months? |
@clsmyth v1.26.0 is planned for 2023-02-13. |
@srebhan Thank you for taking the time to look at this! I'm sorry my change resulted in so much work! I can confirm that the PR build works for tagging on the Arista devices that I was targeting. |
@bewing no worries! The worst thing is bit-rotting code... :-) |
After the update to Telegraf 1.23.4 it looks like dynamic interface description tagging doesn't work anymore.
Can it be related to a fix introduced for #11006?
System info
Telegraf 1.23.4, Rocky Linux 8.6
dnf install telegraf
Steps to reproduce
Expected behavior
To be able to filter based on the interface description in association with traffic values
Actual behavior
Tags are not added
Additional info
Telegraf config
Output of telegraf -config /etc/telegraf/telegraf.conf -test-wait 10
The text was updated successfully, but these errors were encountered: