Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs.gnmi with dynamic tagging won't work #11778

Closed
madd2008 opened this issue Sep 8, 2022 · 27 comments · Fixed by #12415 or #12512
Closed

inputs.gnmi with dynamic tagging won't work #11778

madd2008 opened this issue Sep 8, 2022 · 27 comments · Fixed by #12415 or #12512
Assignees
Labels
area/gnmi bug unexpected problem or unintended behavior

Comments

@madd2008
Copy link

madd2008 commented Sep 8, 2022

After the update to Telegraf 1.23.4 it looks like dynamic interface description tagging doesn't work anymore.
Can it be related to a fix introduced for #11006?

System info

Telegraf 1.23.4, Rocky Linux 8.6
dnf install telegraf

Steps to reproduce

  1. Juniper MX Junos 19.4
  2. Install Telegraf from the repo
  3. Apply standard configuration (supplied below)

Expected behavior

To be able to filter based on the interface description in association with traffic values

Actual behavior

Tags are not added

Additional info

Telegraf config

[[inputs.gnmi]]
  ## Address and port of the gNMI GRPC server
  addresses = ["dev-01:6666", "dev-02:6666", "and_many_more"]
  ## redial in case of failures after
  redial = "10s"

  [[inputs.gnmi.subscription]]
    ## Name of the measurement that will be emitted
    name = "ifcounters"

    ## Origin and path of the subscription
    ## See: https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#222-paths
    ##
    ## origin usually refers to a (YANG) data model implemented by the device
    ## and path to a specific substructure inside it that should be subscribed to (similar to an XPath)
    ## YANG models can be found e.g. here: https://github.com/YangModels/yang/tree/master/vendor/cisco/xr
    origin = "openconfig-interfaces"
    path = "/interfaces/interface/state/counters"

    # Subscription mode (one of: "target_defined", "sample", "on_change") and interval
    subscription_mode = "sample"
    sample_interval = "10s"

    ## Suppress redundant transmissions when measured values are unchanged
    # suppress_redundant = false

    ## If suppression is enabled, send updates at least every X seconds anyway
    # heartbeat_interval = "60s"

  [[inputs.gnmi.subscription]]
    name = "descr"
    origin = "openconfig-interfaces"
    path = "/interfaces/interface/state/description"
    subscription_mode = "on_change"

    # If tag_only is set, the subscription in question will be utilized to maintain a map of
    # tags to apply to other measurements emitted by the plugin, by matching path keys
    # All fields from the tag-only subscription will be applied as tags to other readings,
    # in the format <name>_<fieldBase>.
    tag_only = true

Output of telegraf -config /etc/telegraf/telegraf.conf -test-wait 10

> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=13i,in_broadcast_pkts=8633i,in_multicast_pkts=12814821i,in_octets=981767613326715i,in_pkts=1124568146100i,in_unicast_pkts=1124555417453i,out_broadcast_pkts=8808i,out_discards=2i,out_errors=4i,out_multicast_pkts=5394391i,out_octets=5589112753852769i,out_pkts=4608716206766i,out_unicast_pkts=4608711486750i 1662597951606000000
> ifcounters,dc=east,host=server,name=et-0/1/1,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=13i,in_broadcast_pkts=86615i,in_errors=10i,in_multicast_pkts=383205i,in_octets=944525811890809i,in_pkts=718749167550i,in_unicast_pkts=718749604491i,out_broadcast_pkts=875i,out_multicast_pkts=904574i,out_octets=25555050971768i,out_pkts=39129065398i,out_unicast_pkts=39129021441i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/9:0,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=7i,in_broadcast_pkts=2444788499i,in_errors=5i,in_multicast_pkts=1902455296i,in_octets=1904351925910325i,in_pkts=1707266740256i,in_unicast_pkts=1702919640798i,out_broadcast_pkts=826243i,out_multicast_pkts=943539i,out_octets=791719579349507i,out_pkts=863796044016i,out_unicast_pkts=863794638830i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/9:1,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=1i,in_broadcast_pkts=2087i,in_multicast_pkts=3549i,in_unicast_pkts=88576i,out_multicast_pkts=5741737i,out_octets=67889496i,out_pkts=200264i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:1,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=7i,in_broadcast_pkts=12i,in_multicast_pkts=9600373i,in_octets=2602493631228924i,in_pkts=2081532056174i,in_unicast_pkts=2081522455797i,out_broadcast_pkts=7986i,out_multicast_pkts=9828830i,out_octets=107746949477227i,out_pkts=169123822683i,out_unicast_pkts=169123467937i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:2,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=7i,in_broadcast_pkts=70i,in_multicast_pkts=9919242i,in_octets=286317627738i,in_pkts=212758672i,in_unicast_pkts=202839373i,out_multicast_pkts=9921182i,out_octets=103863384340i,out_pkts=80235470i,out_unicast_pkts=79889477i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:3,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=7i,in_broadcast_pkts=4403i,in_multicast_pkts=9873871i,in_octets=1170447534785i,in_pkts=1433191302i,in_unicast_pkts=1423313157i,out_broadcast_pkts=1890i,out_multicast_pkts=9921127i,out_octets=2223399341755i,out_pkts=2023645969i,out_unicast_pkts=2023298137i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=1i,in_broadcast_pkts=440i,in_multicast_pkts=2674i,in_octets=74250193i,in_pkts=1032365i,in_unicast_pkts=1029254i,out_broadcast_pkts=24i,out_multicast_pkts=345841i,out_octets=197210852i,out_pkts=1257982i,out_unicast_pkts=912117i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=3i,in_broadcast_pkts=7i,in_errors=2i,in_multicast_pkts=9594604i,in_octets=120595855932437i,in_pkts=91051228885i,in_unicast_pkts=91041644716i,out_broadcast_pkts=7763i,out_multicast_pkts=665908i,out_octets=48825280168194i,out_pkts=44040665321i,out_unicast_pkts=44040309106i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:2,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=1i,in_multicast_pkts=9919341i,in_octets=34873459303i,in_pkts=39802668i,in_unicast_pkts=29883365i,out_broadcast_pkts=2554i,out_multicast_pkts=9921299i,out_octets=215401827173i,out_pkts=154942252i,out_unicast_pkts=154593513i 1662597951606000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:3,path=/interfaces/interface,source=1.1.1.8 carrier_transitions=1i,in_multicast_pkts=9864553i,in_octets=1095377410284i,in_pkts=1384580298i,in_unicast_pkts=1374715924i,out_broadcast_pkts=2539i,out_multicast_pkts=9921265i,out_octets=2255828097828i,out_pkts=2067650380i,out_unicast_pkts=2067301750i 1662597951606000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.3 carrier_transitions=7i,in_broadcast_pkts=6612i,in_multicast_pkts=17448436i,in_octets=382659502526757i,in_pkts=453937956905i,in_unicast_pkts=453920501868i,out_broadcast_pkts=6589i,out_multicast_pkts=17447656i,out_octets=11807583297868898i,out_pkts=12464586983657i,out_unicast_pkts=12464585698231i 1662598250599000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=45i,in_broadcast_pkts=20922i,in_errors=463320i,in_multicast_pkts=29501973i,in_octets=1118311875158751i,in_pkts=1229239471379i,in_unicast_pkts=1229210026436i,out_broadcast_pkts=20597i,out_multicast_pkts=34430960i,out_octets=10439544090885043i,out_pkts=8375159347372i,out_unicast_pkts=8375147814897i 1662597648460000000
> ifcounters,dc=east,host=server,name=et-0/1/1,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=3i,in_broadcast_pkts=36584i,in_multicast_pkts=223051i,in_octets=1252477900647321i,in_pkts=985812173393i,in_unicast_pkts=985813568689i,out_broadcast_pkts=841i,out_multicast_pkts=177237i,out_octets=92740736820787i,out_pkts=96995815804i,out_unicast_pkts=96995880009i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:0,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=9i,in_broadcast_pkts=714292770i,in_errors=96i,in_multicast_pkts=720374658i,in_octets=993620750481534i,in_pkts=788778938819i,in_unicast_pkts=787344321277i,out_broadcast_pkts=562663i,out_multicast_pkts=1297005i,out_octets=356459854845718i,out_pkts=352644398356i,out_unicast_pkts=352643204632i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:1,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=21i,in_broadcast_pkts=559818390i,in_multicast_pkts=1140623707i,in_octets=557311597886256i,in_pkts=436625864334i,in_unicast_pkts=434925774334i,out_broadcast_pkts=481654i,out_multicast_pkts=9173862i,out_octets=380691393198519i,out_pkts=437805602244i,out_unicast_pkts=437805125626i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:3,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=1i,out_multicast_pkts=22860i,out_octets=7635240i,out_pkts=22860i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=15i,in_broadcast_pkts=14i,in_errors=2i,in_multicast_pkts=16798195i,in_octets=7636392564384300i,in_pkts=6167974935065i,in_unicast_pkts=6167958136865i,out_broadcast_pkts=13936i,out_multicast_pkts=17256110i,out_octets=288408764823385i,out_pkts=341767560925i,out_unicast_pkts=341766934790i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=3i,in_broadcast_pkts=39i,in_errors=2i,in_multicast_pkts=1741i,in_octets=24517766i,in_pkts=252107i,in_unicast_pkts=250327i,out_broadcast_pkts=3191i,out_multicast_pkts=284326i,out_octets=339476459i,out_pkts=664525i,out_unicast_pkts=377006i 1662597648460000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:3,path=/interfaces/interface,source=1.1.1.9 carrier_transitions=3i,out_multicast_pkts=22863i,out_octets=7636242i,out_pkts=22863i 1662597648460000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=5i,in_broadcast_pkts=20331i,in_multicast_pkts=25826082i,in_octets=802510539247200i,in_pkts=980522000933i,in_unicast_pkts=980496200985i,out_broadcast_pkts=19545i,out_multicast_pkts=29487470i,out_octets=4667493279207243i,out_pkts=5123784611807i,out_unicast_pkts=5123775750519i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:1,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=1i,in_broadcast_pkts=3i,in_multicast_pkts=15575755i,in_octets=2794576689821689i,in_pkts=2152672104567i,in_unicast_pkts=2152656721290i,out_broadcast_pkts=13028i,out_multicast_pkts=16095148i,out_octets=115303244160636i,out_pkts=141697976751i,out_unicast_pkts=141697427309i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:2,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=1i,in_broadcast_pkts=6591i,in_multicast_pkts=11707978i,in_octets=13481227318151i,in_pkts=12249397813i,in_unicast_pkts=12237684492i,out_broadcast_pkts=5338i,out_multicast_pkts=12092171i,out_octets=80459328660615i,out_pkts=69862308815i,out_unicast_pkts=69861871074i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:3,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=125i,in_broadcast_pkts=1940i,in_multicast_pkts=521433i,in_octets=74947241i,in_pkts=681629i,in_unicast_pkts=158261i,out_broadcast_pkts=107i,out_multicast_pkts=793151i,out_octets=119660063i,out_pkts=375499i,out_unicast_pkts=118947i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=33i,in_broadcast_pkts=348i,in_multicast_pkts=26970i,in_octets=872258393i,in_pkts=2598198i,in_unicast_pkts=2570880i,out_broadcast_pkts=1733i,out_multicast_pkts=287700i,out_octets=4126159206i,out_pkts=4815988i,out_unicast_pkts=4526555i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.7 carrier_transitions=1i,in_broadcast_pkts=1130474577i,in_errors=2448i,in_multicast_pkts=1560948504i,in_octets=1768405939906158i,in_pkts=2880495912265i,in_unicast_pkts=2877805628215i,out_broadcast_pkts=951957i,out_multicast_pkts=651679i,out_octets=272956931573519i,out_pkts=455712534454i,out_unicast_pkts=455711286172i 1662597838116000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.13 carrier_transitions=3i,in_broadcast_pkts=21938i,in_multicast_pkts=980i,in_octets=18457253i,in_pkts=251788i,in_unicast_pkts=228870i,out_broadcast_pkts=1705i,out_multicast_pkts=124527i,out_octets=319147531i,out_pkts=502582i,out_unicast_pkts=376350i 1662597672389000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=13i,in_broadcast_pkts=19309i,in_multicast_pkts=25119983i,in_octets=2164461413469611i,in_pkts=2340292337154i,in_unicast_pkts=2340267208923i,out_broadcast_pkts=18306i,out_discards=1i,out_errors=2i,out_multicast_pkts=10590058i,out_octets=11130556951079645i,out_pkts=8789724850160i,out_unicast_pkts=8789714911902i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/8:3,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=1i,out_multicast_pkts=20633i,out_octets=6870789i,out_pkts=20633i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:0,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=1i,in_broadcast_pkts=1174424680i,in_errors=594i,in_multicast_pkts=1133594299i,in_octets=3346866224516370i,in_pkts=2721952548803i,in_unicast_pkts=2719644546784i,out_broadcast_pkts=562504i,out_multicast_pkts=1364999i,out_octets=1933093847890596i,out_pkts=2062125963253i,out_unicast_pkts=2062124942735i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=11i,in_broadcast_pkts=7514i,in_multicast_pkts=16712127i,in_octets=7417341790680193i,in_pkts=5809924989433i,in_unicast_pkts=5809908305007i,out_broadcast_pkts=7522i,out_multicast_pkts=17144760i,out_octets=161420797175012i,out_pkts=214665251979i,out_unicast_pkts=214664558358i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=3i,in_broadcast_pkts=94i,in_multicast_pkts=800i,in_octets=23680594i,in_pkts=274111i,in_unicast_pkts=273217i,out_broadcast_pkts=5632i,out_multicast_pkts=86812i,out_octets=327485882i,out_pkts=517284i,out_unicast_pkts=424839i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:2,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=3i,in_broadcast_pkts=65i,in_multicast_pkts=12327593i,in_octets=366523917300081i,in_pkts=260431778262i,in_unicast_pkts=260419450690i,out_broadcast_pkts=10196i,out_multicast_pkts=12619200i,out_octets=69934225808624i,out_pkts=63453708137i,out_unicast_pkts=63453251843i 1662597607673000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:3,path=/interfaces/interface,source=1.1.1.11 carrier_transitions=1i,out_multicast_pkts=20630i,out_octets=6890420i,out_pkts=20630i 1662597607673000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.6 carrier_transitions=5i,in_broadcast_pkts=20487i,in_multicast_pkts=26275379i,in_octets=2869920641066698i,in_pkts=4125053678635i,in_unicast_pkts=4125026963051i,out_broadcast_pkts=19675i,out_multicast_pkts=30345826i,out_octets=7131547624344089i,out_pkts=6119383331573i,out_unicast_pkts=6119372614119i 1662597595233000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:0,path=/interfaces/interface,source=1.1.1.6 carrier_transitions=3i,in_broadcast_pkts=589170361i,in_errors=39i,in_multicast_pkts=502375407i,in_octets=2958151939083444i,in_pkts=2465189318770i,in_unicast_pkts=2464097739971i,out_broadcast_pkts=873642i,out_multicast_pkts=3228412i,out_octets=1313987768697404i,out_pkts=2688055421027i,out_unicast_pkts=2688053323674i 1662597595233000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:1,path=/interfaces/interface,source=1.1.1.6 carrier_transitions=7i,in_broadcast_pkts=102i,in_multicast_pkts=12238151i,in_octets=406762081520912i,in_pkts=348162985242i,in_unicast_pkts=348150735934i,out_broadcast_pkts=9821i,out_multicast_pkts=859568i,out_octets=322068628544135i,out_pkts=262113556037i,out_unicast_pkts=262113075969i 1662597595233000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.6 carrier_transitions=3i,in_broadcast_pkts=8670i,in_multicast_pkts=19856964i,in_octets=3766700957062371i,in_pkts=3307416318496i,in_unicast_pkts=3307397010983i,out_broadcast_pkts=8583i,out_multicast_pkts=19590580i,out_octets=1233849122672094i,out_pkts=1174810370615i,out_unicast_pkts=1174809635543i 1662597595233000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.6 carrier_transitions=3i,in_broadcast_pkts=20090i,in_multicast_pkts=1650i,in_octets=19340354i,in_pkts=221934i,in_unicast_pkts=200194i,out_broadcast_pkts=3298i,out_multicast_pkts=271097i,out_octets=318180007i,out_pkts=603827i,out_unicast_pkts=329432i 1662597595233000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=5i,in_broadcast_pkts=9328i,in_multicast_pkts=13530149i,in_octets=1541182088972242i,in_pkts=1918431475014i,in_unicast_pkts=1918418150637i,out_broadcast_pkts=9096i,out_discards=2i,out_errors=4i,out_multicast_pkts=5695518i,out_octets=3543183581948513i,out_pkts=2913197178320i,out_unicast_pkts=2913192075412i 1662597578537000000
> ifcounters,dc=east,host=server,name=et-0/1/1,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=1i,in_broadcast_pkts=61935196i,in_errors=28i,in_multicast_pkts=157546890i,in_octets=2009610051954088i,in_pkts=1703382485862i,in_unicast_pkts=1703163116721i,out_broadcast_pkts=1403537i,out_multicast_pkts=340265i,out_octets=474394552960658i,out_pkts=679327740893i,out_unicast_pkts=679326382545i 1662597578537000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:3,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=7i,in_broadcast_pkts=15602i,in_multicast_pkts=196i,in_octets=945676i,in_pkts=15795i,out_multicast_pkts=21329i,out_octets=7123886i,out_pkts=21329i 1662597578537000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=1i,in_broadcast_pkts=4706i,in_multicast_pkts=10135905i,in_octets=1453914981614135i,in_pkts=1154043520582i,in_unicast_pkts=1154033536856i,out_broadcast_pkts=4516i,out_multicast_pkts=10475784i,out_octets=1011041861301884i,out_pkts=1189786231822i,out_unicast_pkts=1189786018242i 1662597578537000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=19i,in_broadcast_pkts=95i,in_multicast_pkts=887i,in_octets=44371853i,in_pkts=317851i,in_unicast_pkts=316869i,out_broadcast_pkts=813i,out_multicast_pkts=88366i,out_octets=355498864i,out_pkts=556759i,out_unicast_pkts=467580i 1662597578537000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:2,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=1i,in_broadcast_pkts=11i,in_multicast_pkts=10135306i,in_octets=79794357733003i,in_pkts=58380860506i,in_unicast_pkts=58370726092i,out_broadcast_pkts=8104i,out_multicast_pkts=702909i,out_octets=55741774880283i,out_pkts=49346431149i,out_unicast_pkts=49346054612i 1662597578537000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:3,path=/interfaces/interface,source=1.1.1.5 carrier_transitions=7i,out_multicast_pkts=108162i,out_octets=36302334i,out_pkts=108162i 1662597578537000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=3i,in_broadcast_pkts=9195i,in_multicast_pkts=13636231i,in_octets=1305591963024417i,in_pkts=1463250030121i,in_unicast_pkts=1463236367097i,out_broadcast_pkts=9365i,out_multicast_pkts=15603221i,out_octets=6011662653778699i,out_pkts=5085285576337i,out_unicast_pkts=5085280058580i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/8:3,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=1i,out_multicast_pkts=237927i,out_octets=79229691i,out_pkts=237927i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:0,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=1i,in_broadcast_pkts=2i,in_multicast_pkts=10225459i,in_octets=4285178163911957i,in_pkts=3603677849176i,in_unicast_pkts=3603667550306i,out_broadcast_pkts=8524i,out_multicast_pkts=10567048i,out_octets=479830844074696i,out_pkts=443976610016i,out_unicast_pkts=443976223429i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:1,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=1i,in_broadcast_pkts=1050759055i,in_errors=3426i,in_multicast_pkts=754724433i,in_octets=1206080115317287i,in_pkts=1076358435312i,in_unicast_pkts=1074552934162i,out_broadcast_pkts=895534i,out_multicast_pkts=993942i,out_octets=448967837117562i,out_pkts=623584553976i,out_unicast_pkts=623582987743i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=1i,in_broadcast_pkts=4705i,in_multicast_pkts=10222506i,in_octets=8098977674576i,in_pkts=6754859124i,in_unicast_pkts=6744631913i,out_broadcast_pkts=4583i,out_multicast_pkts=10567043i,out_octets=75292613027752i,out_pkts=64431492334i,out_unicast_pkts=64431116859i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=75i,in_broadcast_pkts=2694i,in_multicast_pkts=54604i,in_octets=71585183i,in_pkts=1047487i,in_unicast_pkts=990189i,out_broadcast_pkts=3790i,out_multicast_pkts=69375i,out_octets=3882609001i,out_pkts=2876831i,out_unicast_pkts=2803658i 1662598251118000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:2,path=/interfaces/interface,source=1.1.1.12 carrier_transitions=7i,in_broadcast_pkts=112848496i,in_multicast_pkts=276511119i,in_octets=512459831629483i,in_pkts=400865206250i,in_unicast_pkts=400475841625i,out_broadcast_pkts=204728i,out_discards=1i,out_errors=2i,out_multicast_pkts=300222i,out_octets=301492703554515i,out_pkts=331274484773i,out_unicast_pkts=331274264412i 1662598251118000000
> ifcounters,dc=east,host=server,name=et-0/1/2,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=7i,in_broadcast_pkts=12118i,in_multicast_pkts=14867496i,in_octets=1030682192488292i,in_pkts=1169286120151i,in_unicast_pkts=1169271240553i,out_broadcast_pkts=6044i,out_multicast_pkts=15002607i,out_octets=24801355459865203i,out_pkts=19884513469110i,out_unicast_pkts=19884512679574i 1662598232212000000
> ifcounters,dc=east,host=server,name=et-0/1/0,path=/interfaces/interface,source=1.1.1.10 carrier_transitions=3i,in_broadcast_pkts=14522i,in_multicast_pkts=21056341i,in_octets=1078808561883764i,in_pkts=1345991783723i,in_unicast_pkts=1345970696670i,out_broadcast_pkts=14325i,out_multicast_pkts=24173755i,out_octets=11166207498799274i,out_pkts=8787296871406i,out_unicast_pkts=8787288387003i 1662597699407000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:0,path=/interfaces/interface,source=1.1.1.10 carrier_transitions=5i,in_broadcast_pkts=163i,in_multicast_pkts=879i,in_octets=125586617i,in_pkts=442671i,in_unicast_pkts=441629i,out_broadcast_pkts=153i,out_multicast_pkts=233708i,out_octets=400779347i,out_pkts=837946i,out_unicast_pkts=604084i 1662597699407000000
> ifcounters,dc=east,host=server,name=xe-0/1/10:3,path=/interfaces/interface,source=1.1.1.10 carrier_transitions=5i,in_broadcast_pkts=8429i,in_multicast_pkts=16849i 1662597699407000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.10 carrier_transitions=7i,in_broadcast_pkts=8426i,in_multicast_pkts=16849i,out_multicast_pkts=205i,out_octets=66215i,out_pkts=205i 1662597699407000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.10 carrier_transitions=1i,in_broadcast_pkts=3i,in_multicast_pkts=15841941i,in_octets=9589977530959939i,in_pkts=7542282989920i,in_unicast_pkts=7542267067025i,out_broadcast_pkts=13203i,out_multicast_pkts=16364912i,out_octets=700680256020808i,out_pkts=776296917126i,out_unicast_pkts=776296315879i 1662597699407000000
> ifcounters,dc=east,host=server,name=et-0/1/3,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=7i,in_broadcast_pkts=56375i,in_errors=6i,in_multicast_pkts=44787025i,in_octets=32001774383492488i,in_pkts=25993360772401i,in_unicast_pkts=25993320751228i,out_broadcast_pkts=54115i,out_multicast_pkts=35013453i,out_octets=1378981677943826i,out_pkts=1532660820714i,out_unicast_pkts=1532640208329i 1662598232212000000
> ifcounters,dc=east,host=server,name=et-0/1/5,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=5i,in_broadcast_pkts=6i,in_errors=3507i,in_multicast_pkts=60402i,in_octets=18573256247447134i,in_pkts=14516135861636i,in_unicast_pkts=14516135616775i,out_broadcast_pkts=8999i,out_discards=2i,out_errors=4i,out_multicast_pkts=389840i,out_octets=12141266741420295i,out_pkts=12830355673451i,out_unicast_pkts=12830350755299i 1662598232212000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:0,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=1i,in_broadcast_pkts=20573i,in_multicast_pkts=8156235i,in_octets=8567053587i,in_pkts=37747313i,in_unicast_pkts=29571164i,out_broadcast_pkts=6671i,out_multicast_pkts=523054i,out_octets=404268936241i,out_pkts=468488154i,out_unicast_pkts=467958421i 1662598232212000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:1,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=19i,in_broadcast_pkts=132170i,in_multicast_pkts=14160677i,in_octets=71282658146i,in_pkts=99712633i,in_unicast_pkts=85809358i,out_broadcast_pkts=6441i,out_multicast_pkts=14490955i,out_octets=16277982577850i,out_pkts=11957669049i,out_unicast_pkts=11957156789i 1662598232212000000
> ifcounters,dc=east,host=server,name=xe-0/1/11:3,path=/interfaces/interface,source=1.1.1.4 carrier_transitions=9i,in_broadcast_pkts=5539i,in_multicast_pkts=12429035i,in_octets=704119810707i,in_pkts=774809755i,in_unicast_pkts=762378379i,out_broadcast_pkts=5454i,out_multicast_pkts=12496647i,out_octets=3289248376842i,out_pkts=2305722562i,out_unicast_pkts=2305280771i 1662598232212000000
> ifcounters,dc=east,host=server,name=em2,path=/interfaces/interface,source=1.1.1.5 in_octets=35384892152i,in_pkts=113908689i,last_clear="Never",out_octets=6964380655i,out_pkts=63998069i 1662597579056845562
> ifcounters,dc=east,host=server,name=em3,path=/interfaces/interface,source=1.1.1.5 in_octets=384758144245i,in_pkts=1100291642i,last_clear="Never",out_octets=130566232414i,out_pkts=933974468i 1662597579057320665
> ifcounters,dc=east,host=server,name=em4,path=/interfaces/interface,source=1.1.1.5 in_octets=7514i,in_pkts=41i,last_clear="Never",out_octets=847526238i,out_pkts=16950527i 1662597579057783180
> ifcounters,dc=east,host=server,name=em4,path=/interfaces/interface,source=1.1.1.8 in_octets=7514i,in_pkts=41i,last_clear="Never",out_octets=1154525118i,out_pkts=23090503i 1662597952884469969
> ifcounters,dc=east,host=server,name=fxp0,path=/interfaces/interface,source=1.1.1.8 in_octets=16121i,in_pkts=94i,last_clear="Never",out_octets=50530604i,out_pkts=164655i 1662597952884924411
> ifcounters,dc=east,host=server,name=gre,path=/interfaces/interface,source=1.1.1.8 last_clear="Never" 1662597952885357872
> ifcounters,dc=east,host=server,name=ipip,path=/interfaces/interface,source=1.1.1.8 last_clear="Never" 1662597952885784151
> ifcounters,dc=east,host=server,name=lo0,path=/interfaces/interface,source=1.1.1.8 in_octets=896053135129i,in_pkts=380444922i,last_clear="Never",out_octets=896053135129i,out_pkts=380444922i 1662597952886240026
> ifcounters,dc=east,host=server,name=em2,path=/interfaces/interface,source=1.1.1.9 in_octets=46974843733i,in_pkts=151843636i,last_clear="Never",out_octets=9313450420i,out_pkts=85641556i 1662597649599963803
> ifcounters,dc=east,host=server,name=em3,path=/interfaces/interface,source=1.1.1.9 in_octets=727994935088i,in_pkts=3372369178i,last_clear="Never",out_octets=133025964943i,out_pkts=1034128685i 1662597649600407607
> ifcounters,dc=east,host=server,name=pimd,path=/interfaces/interface,source=1.1.1.9 last_clear="Never" 1662597649603879269
> ifcounters,dc=east,host=server,name=pime,path=/interfaces/interface,source=1.1.1.9 last_clear="Never" 1662597649604312751
> ifcounters,dc=east,host=server,name=tap,path=/interfaces/interface,source=1.1.1.9 last_clear="Never" 1662597649604757159
> ifcounters,dc=east,host=server,name=dsc,path=/interfaces/interface,source=1.1.1.10 last_clear="Never" 1662597699752661127
> ifcounters,dc=east,host=server,name=em2,path=/interfaces/interface,source=1.1.1.10 in_octets=39886763735i,in_pkts=130041546i,last_clear="Never",out_octets=7287917015i,out_pkts=71352687i 1662597699753139424
> ifcounters,dc=east,host=server,name=em3,path=/interfaces/interface,source=1.1.1.10 in_octets=516715937353i,in_pkts=2343617484i,last_clear="Never",out_octets=107780193554i,out_pkts=771143519i 1662597699753619244
> ifcounters,dc=east,host=server,name=em4,path=/interfaces/interface,source=1.1.1.10 last_clear="Never",out_octets=976039360i,out_pkts=19520788i 1662597699754049300
> ifcounters,dc=east,host=server,name=fxp0,path=/interfaces/interface,source=1.1.1.10 in_octets=769788212i,in_pkts=2250846i,last_clear="Never",out_octets=130541854i,out_pkts=442075i 1662597699754502207
> ifcounters,dc=east,host=server,name=gre,path=/interfaces/interface,source=1.1.1.10 last_clear="Never" 1662597699754936017
> ifcounters,dc=east,host=server,name=ipip,path=/interfaces/interface,source=1.1.1.10 last_clear="Never" 1662597699755362496
> ifcounters,dc=east,host=server,name=lo0,path=/interfaces/interface,source=1.1.1.10 in_octets=635477815217i,in_pkts=287954843i,last_clear="Never",out_octets=635477815217i,out_pkts=287954843i 1662597699755816135
> ifcounters,dc=east,host=server,name=lsi,path=/interfaces/interface,source=1.1.1.10 last_clear="Never" 1662597699756245423
@MyaLongmire
Copy link
Contributor

@madd2008 sorry to hear you are having issues.

What is your output supposed to look like? What was the last version where this was working?

The most recent bug fix for gnmi I could find was this pr. Do you think that could be the cause? That pr was released in 1.23.2 so the timing is a little suspicious.

@madd2008
Copy link
Author

madd2008 commented Sep 23, 2022

@MyaLongmire ifcounters should contain a tag containing interface name based on this

[[inputs.gnmi.subscription]]
    name = "descr"
    origin = "openconfig-interfaces"
    path = "/interfaces/interface/state/description"
    subscription_mode = "on_change"

    # If tag_only is set, the subscription in question will be utilized to maintain a map of
    # tags to apply to other measurements emitted by the plugin, by matching path keys
    # All fields from the tag-only subscription will be applied as tags to other readings,
    # in the format <name>_<fieldBase>.
    tag_only = true

And it doesn't do it anymore.
I've finally redeployed it and the issue is still there.

@madd2008
Copy link
Author

I've downloaded and installed v1.23.1 [2022-07-05] and it works perfectly fine
it's definitely a #Bug after #11019
Please take a look

@madd2008
Copy link
Author

madd2008 commented Sep 29, 2022

@powersj
Copy link
Contributor

powersj commented Sep 29, 2022

@bewing is there something that was missed or an obvious change required with this issue?

@bewing
Copy link
Contributor

bewing commented Sep 30, 2022

I unfortunately do not have any access to any Juniper MX hardware to test at this time -- is it possible to reproduce this issue with a vMX instance? I can probably work on getting access to a vMX image file.

@bewing
Copy link
Contributor

bewing commented Sep 30, 2022

and btw this https://github.com/influxdata/telegraf/pull/11019/files#diff-8f015c9f22f0f8f4f8ee17b671e6d8f3ffa1871b86fc765a96e00d9d45ba0f39R507-R510 was never translated to https://github.com/influxdata/telegraf/blob/master/plugins/inputs/gnmi/README.md

that could have solved the issue. Will try in a day or so.

It appears the doc change was reverted by #11489. I do not know the backstory there

@madd2008
Copy link
Author

I unfortunately do not have any access to any Juniper MX hardware to test at this time -- is it possible to reproduce this issue with a vMX instance? I can probably work on getting access to a vMX image file.

Yes, I believe so. Any Juniper device/VM(with the same Junos version) should provide a similar outcome.
I would still ask to try vMX on Junos 19.4 if possible, but also don't believe that any other version(which supports telemetry) will provide another result.

@madd2008
Copy link
Author

madd2008 commented Oct 11, 2022 via email

@Hipska Hipska added bug unexpected problem or unintended behavior area/gnmi labels Nov 30, 2022
@clsmyth
Copy link

clsmyth commented Dec 7, 2022

i am on the same team as OP. i have taken over this effort. I tried the new config discussed above, with a current version of telegraf (1.24.4-1) and it didn't work...population of the "description" field didn't happen in any of the messages. below are example configs and messages. like OP said, we don't think this is a problem specific to some junos version. just try it on whatever you have :-)

CONFIG USED (telegraf-1.23.1-1)

[[inputs.gnmi]]
  addresses     = ["rt-01:nnnnn", "rt-02:nnnnn"]
  name_override = "gnmi"
  redial        = "10s"
  [[inputs.gnmi.subscription]]
    name              = "ifcounters"
    origin            = "openconfig-interfaces"
    path              = "/interfaces/interface/state/counters"
    subscription_mode = "sample"
    sample_interval   = "10s"
  [[inputs.gnmi.subscription]]
    name              = "descr"
    origin            = "openconfig-interfaces"
    path              = "/interfaces/interface/state/description"
    subscription_mode = "on_change"
    tag_only          = true

GOOD OUTPUT (influx format; newlines inserted for readability):

gnmi,
dc=DC1
descr/description=connection-to-isp <-- note: this is what we are looking for
host=telegraf-server,
name=xe-0/1/1,
path=/interfaces/interface,
source=router-name
in_pkts=2424613070143i,
in_octets=2511143630925506i,
in_unicast_pkts=2424609826906i,
in_multicast_pkts=3452255i,
in_broadcast_pkts=11303i,
out_pkts=414187016072i,
out_octets=446151036442764i,
out_unicast_pkts=414183552977i,
out_multicast_pkts=3451997i,
out_broadcast_pkts=11367i,
carrier_transitions=3i
1670443206244000000

CONFIG USED (telegraf-1.24.4-1)

[[inputs.gnmi]]
  addresses     = ["rt-01:nnnnn", "rt-02:nnnnn"]
  name_override = "gnmi"
  redial        = "10s"
  [[inputs.gnmi.subscription]]
    name              = "ifcounters"
    origin            = "openconfig"
    path              = "/interfaces/interface/state/counters"
    subscription_mode = "sample"
    sample_interval   = "10s"
  [[inputs.gnmi.tag_subscription]]
    name              = "descr"
    origin            = "openconfig"
    path              = "/interfaces/interface/state/description"
    subscription_mode = "on_change"
    elements          = ["interface"]

BAD OUTPUT (influx format; newlines inserted for readability):

gnmi,
dc=DC1
host=telegraf-server,
name=xe-0/1/1,
path=/interfaces/interface,
source=router-name
in_pkts=2424385633056i,
in_octets=2510946168450711i,
in_unicast_pkts=2424382306618i,
in_multicast_pkts=3451845i,
in_broadcast_pkts=11302i,
out_pkts=414186729272i,
out_octets=446150958047418i,
out_unicast_pkts=414183266459i,
out_multicast_pkts=3451589i,
out_broadcast_pkts=11367i,
carrier_transitions=3i
1670441755354000000

@srebhan
Copy link
Member

srebhan commented Dec 19, 2022

@madd2008 and @clsmyth, please run the binary in #12415 (once it is built by CI) with --debug enabled and post the debug output (especially the line starting with Tag-subscription update for ....

@srebhan srebhan self-assigned this Dec 19, 2022
@clsmyth
Copy link

clsmyth commented Dec 23, 2022

@srebhan thank you for looking into this. We have done the needful and noted that the problem persists with the updated binary. But we gathered the requested output. Please find it attached.
telegraf.log.gz

@clsmyth
Copy link

clsmyth commented Dec 27, 2022

@srebhan i also noticed that, in the tarball i downloaded for 1.26.0, the etc/telegraf/telegraf.conf still references the "tag_only" config for gnmi. i am not sure how this file relates to files that did change in the PR, like README.md and sample.conf. Those changed files are not present in the tarball.

@cjonesdialpad
Copy link

Confirming that I'm seeing this issue as well and that you've seen my logs on Slack. I'm okay with using the version pre-PR breakage but hopefully this gets resolved. Maybe roll back that PR?

@cjonesdialpad
Copy link

@powersj im looking through 11228ee and don't see where the code was rolled back to pre- PR #11019 that broke tagging. Can you help me understand?

@powersj
Copy link
Contributor

powersj commented Jan 9, 2023

Can you help me understand?

I reviewed and merged a PR to update some docs. Looks like it was tagged to fix this issue and per a previous comment it doesn't look like it actually fixed this one. @srebhan thoughts?

@srebhan
Copy link
Member

srebhan commented Jan 16, 2023

@cjonesdialpad and @madd2008 please test the binary in #12512 and let me know if that fixes the issue!

@clsmyth
Copy link

clsmyth commented Jan 19, 2023

i downloaded the binary with the 3 additional commits from 18 jan 12:15...still broken for me. i have attached the log. i am still using the old-style config with "tag_only".

telegraf.log.gz

srebhan added a commit to srebhan/telegraf that referenced this issue Jan 19, 2023
@cjonesdialpad
Copy link

The latest build in PR #12512 has successfully fixed both the old tag_only syntax, as well as the newer tag_subscription syntax for me!

@clsmyth
Copy link

clsmyth commented Jan 19, 2023

The latest build in PR #12512 has successfully fixed the old tag_only syntax for me. HOWEVER i cannot get the new "tag_subscription" syntax to work. I am configuring exactly as described in this link: https://github.com/influxdata/telegraf/tree/master/plugins/inputs/gnmi

this is my config:

[[inputs.gnmi]]
  addresses     = ["redacted:32767", "also-redacted:32767"]
  name_override = "gnmi_ifcounters"
  redial        = "10s"
  [[inputs.gnmi.subscription]]
    name              = "ifcounters"
    origin            = "openconfig-interfaces"
    path              = "/interfaces/interface/state/counters"
    subscription_mode = "sample"
    sample_interval   = "10s"

  [[inputs.gnmi.tag_subscription]]
    name              = "descr"
    origin            = "openconfig-interfaces"
    path              = "/interfaces/interface/state"
    subscription_mode = "on_change"
    elements          = ["description", "interface"]

@cjonesdialpad
Copy link

This is what I'm using successfully:

  addresses = ["redacted:32767"]

  [[inputs.gnmi.tag_subscription]]
    name = "descr"
    origin = "openconfig"
    path = "/interfaces/interface/subinterfaces/subinterface/state/description"
    subscription_mode = "on_change"
    elements = ["interface", "subinterface"]

  [[inputs.gnmi.subscription]]
    name = "interfaces_logical_status"
    origin = "openconfig"
    path = "/interfaces/interface/subinterfaces/subinterface/state/oper-status"
    subscription_mode = "on_change"

@clsmyth
Copy link

clsmyth commented Jan 19, 2023

THANKS @cjonesdialpad ... i adjusted my config and it works!

  [[inputs.gnmi.tag_subscription]]
    name              = "descr"
    origin            = "openconfig-interfaces"
    path              = "/interfaces/interface/state/description"
    subscription_mode = "on_change"
    elements          = ["interface"]

@srebhan , @powersj , i am satisfied with this fix...thanks very much! when will it be released into the repos? :-)

@srebhan
Copy link
Member

srebhan commented Jan 20, 2023

@clsmyth the change I had to make is massive, so I maybe need to break-up the PR into smaller, more digestible ones. We are working on getting this approved and merged, but it might be v1.26. Until then you can use the binary built in the PR...

@clsmyth
Copy link

clsmyth commented Jan 20, 2023

@srebhan that's OK...we have telegraf-1.23.1-1 pinned in our server. Having an out-of-date version installed is not causing us any trouble...yet :-) If 1.26 becomes the target version for this fix, could you perhaps share a rough estimate of what that timeline would look like for that release, please? A month? 2 months?

@srebhan
Copy link
Member

srebhan commented Jan 23, 2023

@clsmyth v1.26.0 is planned for 2023-02-13.

@bewing
Copy link
Contributor

bewing commented Jan 23, 2023

@srebhan Thank you for taking the time to look at this! I'm sorry my change resulted in so much work!

I can confirm that the PR build works for tagging on the Arista devices that I was targeting.

@srebhan
Copy link
Member

srebhan commented Jan 23, 2023

@bewing no worries! The worst thing is bit-rotting code... :-)

srebhan added a commit to srebhan/telegraf that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi bug unexpected problem or unintended behavior
Projects
None yet
8 participants