Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in ping plugin #443

Closed
ut0mt8 opened this issue Dec 15, 2015 · 7 comments · Fixed by #658
Closed

Error in ping plugin #443

ut0mt8 opened this issue Dec 15, 2015 · 7 comments · Fixed by #658
Labels
bug unexpected problem or unintended behavior

Comments

@ut0mt8
Copy link

ut0mt8 commented Dec 15, 2015

Hello,

The doc (and the code) mention :

ping timeout, in s. 0 == no timeout (ping -t )
timeout = 0.0

That is absolutely not true, at least on debian linux ,
-t is the flag for specifie ttl,
-W is the right option to use

Thks.

@sparrc sparrc added the bug unexpected problem or unintended behavior label Dec 15, 2015
@sparrc
Copy link
Contributor

sparrc commented Dec 15, 2015

thanks for the report

@xor-gate
Copy link

Under the hood the ping plugin is not really cross-platform because it exec's directly the system /bin/ping. See also #496

@sparrc
Copy link
Contributor

sparrc commented Jan 15, 2016

closing in favor of #496

@sparrc sparrc closed this as completed Jan 15, 2016
@HackedServer
Copy link

Since the ping plugin isn't going to be replaced with a Go ping plugin, this issue should be reopened and resolved.

@sparrc
Copy link
Contributor

sparrc commented Feb 6, 2016

true, will do 👍

@xor-gate
Copy link

xor-gate commented Feb 7, 2016

@sparrc so as I can see the native golang ping implementation has issues with reporting the incorrect latency?

@sparrc
Copy link
Contributor

sparrc commented Feb 7, 2016

@xor-gate, nope, Telegraf isn't using a native go implementation, there is just one user who seems to have reported differences between executing ping via bash vs. executing via Telegraf, which I still can't explain.

geodimm pushed a commit to miketonks/telegraf that referenced this issue Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants