Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some inputs panic will lead to the telegraf exit #584

Closed
wutz opened this issue Jan 26, 2016 · 2 comments · Fixed by #588
Closed

Some inputs panic will lead to the telegraf exit #584

wutz opened this issue Jan 26, 2016 · 2 comments · Fixed by #588

Comments

@wutz
Copy link

wutz commented Jan 26, 2016

I expect only those inputs exit, instead of the telegraf exit.

@zstyblik
Copy link
Contributor

@wutaizeng dealing with errors is rather difficult eg. closing connections, stopping threads, rollbacks etc. aka cleaning up, so when something goes wrong, crashing loud actually is the best way to go.
Also, it might serve as a motivation to actually fix things.

My $0.02USD.

@tripledes
Copy link

@zstyblik I agree on the fixing/improving stuff, on the other hand Go offers the recover() function which @wutaizeng uses on his #585 which is supposed to be used in such cases, I would rather have telegraf running and logging errors (which might just be temporary issues) than aborting execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants