Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of PR #107, Allow Telegraf to output data to multiple locations beyond InfluxDB, such as Riemann or Kafka #109

Merged
merged 4 commits into from
Aug 12, 2015

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Aug 12, 2015

\cc @jipperinbham @pauldix @toddboom

This PR supports Telegraf outputting data to multiple locations beyond just InfluxDB. This is a breaking change that requires some changes to the .toml Telegraf configuration file, basically users will need to change their influxdb entry from this:

[influxdb]
url = "http://localhost:8086"
database = "telegraf"

to this

[outputs]
[outputs.influxdb]
url = "http://localhost:8086"
database = "telegraf"

You can find more details in @jipperinbham's original PR here: #107

@@ -23,7 +23,8 @@
# with 'required'. Be sure to edit those to make this configuration work.

# Configuration for influxdb server to send metrics to
[influxdb]
[outputs]
[outputs.influxdb]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little further down it's still showing the old way to define tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I think I caught it in the latest update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I didn't do what I thought we had talked about, my understanding was the config would look like:

[tags]
dc = "us-east-1"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I got confused by a file in ./testdata, fixing that now

@jipperinbham
Copy link
Contributor

@sparrc thanks for making this separate PR to handle the conflicts

Everything looks good to me, just had the one comment.

@sparrc sparrc force-pushed the pr-107 branch 5 times, most recently from e690423 to 2506500 Compare August 12, 2015 16:48
@pauldix
Copy link
Member

pauldix commented Aug 12, 2015

Commented on the other one. The Output interface should have a Close() error function so that Telegraf can be shut down cleanly. +1 on the breaking change

@sparrc
Copy link
Contributor Author

sparrc commented Aug 12, 2015

@jipperinbham @pauldix

Added a commit with a Close() function, although it appears that we can't really do anything with the (I can make a separate PR on influxdb/influxdb to add a Close() function to the client)

sparrc added a commit that referenced this pull request Aug 12, 2015
Merge of PR #107, Allow Telegraf to output data to multiple locations beyond InfluxDB, such as Riemann or Kafka
@sparrc sparrc merged commit ed13924 into master Aug 12, 2015
@sparrc sparrc deleted the pr-107 branch August 12, 2015 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants