Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.suricata): Add ability to parse drop or rejected #13048

Merged
merged 3 commits into from
May 2, 2023
Merged

feat(inputs.suricata): Add ability to parse drop or rejected #13048

merged 3 commits into from
May 2, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 6, 2023

fixes: #13032

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 6, 2023
@powersj powersj mentioned this pull request Apr 6, 2023
Closed
@powersj powersj self-assigned this Apr 10, 2023
@powersj powersj force-pushed the fix/13032 branch 2 times, most recently from 0d16601 to 73e5b2d Compare April 11, 2023 19:24
@influxdata influxdata deleted a comment from telegraf-tiger bot Apr 11, 2023
powersj added 2 commits May 1, 2023 09:09
@powersj
feat(inputs.suricata): v2 message parsing
7729aa8 
Adds a new v2 message parsing that will parse any event type that is
received.

fixes: influxdata#13032
@powersj
tests: update the test cases
0ef0df5
@powersj powersj marked this pull request as ready for review May 1, 2023 15:40
@powersj powersj assigned srebhan and unassigned powersj May 1, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 1, 2023
srebhan
srebhan reviewed May 2, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature, just one comment about a change in behavior...

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 2, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -2.33 % for linux amd64 (new size: 168.8 MB, nightly size 172.8 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan merged commit 9284bda into influxdata:master May 2, 2023
@powersj powersj mentioned this pull request Jun 8, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Jun 13, 2023
Merged
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

There is one more event besides "stats" and "alert". It is "drop" for IPS.
2 participants
@powersj @srebhan