Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.elasticsearch): Allow custom template index settings #15471

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Jun 6, 2024

Summary

Allows users to provide custom template index settings for the Elasticsearch output plugin. Fully flexible for any allowed setting rather than only allowing specific ones.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #13053

@telegraf-tiger telegraf-tiger bot added area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 6, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 6, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one high-level question

plugins/outputs/elasticsearch/README.md Show resolved Hide resolved
@srebhan srebhan removed their assignment Jun 10, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up. There are some conflicts you will need to resolve.

@powersj powersj assigned srebhan and unassigned powersj Jun 10, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @DStrand1!

@srebhan srebhan merged commit 6eef8aa into influxdata:master Jun 11, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jun 11, 2024
@DStrand1 DStrand1 deleted the fix/13053 branch June 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add refresh_interval to configuration parameters in Elasticsearch output plugin
3 participants