chore(logging): Implement early logging #15629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
added
the
ready for final review
powersj
reviewed
Jul 18, 2024
There was a problem hiding this comment.
I think you mentioned this, but if I build and run by hand I see the loading config twice:
❯ ./telegraf --config config.toml
2024-07-18T16:19:12Z I! Loading config: config.toml
2024-07-18T16:19:12Z I! Loading config: config.toml
2024-07-18T16:19:12Z I! Starting Telegraf 1.32.0-ec5b839f brought to you by InfluxData the makers of InfluxDBand with two configs:
❯ ./telegraf --config config.toml --config config.toml
2024-07-18T16:20:03Z I! Loading config: config.toml
2024-07-18T16:20:03Z I! Loading config: config.toml
2024-07-18T16:20:03Z W! Overlapping settings in multiple agent tables are not supported: may cause undefined behavior
2024-07-18T16:20:03Z I! Loading config: config.toml
2024-07-18T16:20:03Z I! Loading config: config.toml
2024-07-18T16:20:03Z W! Overlapping settings in multiple agent tables are not supported: may cause undefined behaviorThe quiet and debug flags look fine.
powersj
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Got another one for you, it seems the debug agent output is now missing:
[agent]
debug = true
omit_hostname = true
[[inputs.mem]]
[[outputs.file]]
Specifically these lines:
2024-07-18T16:38:38Z D! [outputs.file] Wrote batch of 1 metrics in 51.73µs
2024-07-18T16:38:38Z D! [outputs.file] Buffer fullness: 0 / 10000 metrics
DStrand1
reviewed
Jul 25, 2024
plugins/common/shim/goshim.go
Outdated
| @@ -77,6 +77,7 @@ func (s *Shim) watchForShutdown(cancel context.CancelFunc) { | |||
| // Run the input plugins.. | |||
| func (s *Shim) Run(pollInterval time.Duration) error { | |||
| if s.Input != nil { | |||
| fmt.Printf("input logger: %+v (%T)\n", s.log, s.log) | |||
There was a problem hiding this comment.
Looks line an unintentional printf?
powersj
reviewed
Jul 26, 2024
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the logging framework to implement "early" logging to collect log-messages that are issued before the actual logger is set-up. Currently, this is limited to non-fatal messages i.e. everything that survives loading and parsing of the config as well as configuring (but not initializing) the plugins.
Checklist
Related issues