Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.opentelemetry): Add profiles support #15637

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 18, 2024

Summary

This PR adds support for (still experimental) OpenTelemetry profiles making Telegraf the world's first collector to support it. ;-)
As a side effect, the unit-tests are extended to allow for general test-cases to be added similar to other plugins.

Tests were performed using the Elastic otel-profiling agent.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 18, 2024
@srebhan srebhan requested a review from jacobmarble July 18, 2024 13:51
@srebhan srebhan self-assigned this Jul 18, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 1, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Aug 1, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for jumping on this! Let's get this in and get some feedback from users.

@powersj
Copy link
Contributor

powersj commented Aug 1, 2024

This will also need a rebase

@powersj powersj removed their assignment Aug 1, 2024
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one tiny comment

go.mod Outdated Show resolved Hide resolved
Copy link
Member

@jacobmarble jacobmarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Later, you might want to move some of this to https://github.com/influxdata/influxdb-observability but I think this is a good place to try it out.

plugins/inputs/opentelemetry/opentelemetry.go Show resolved Hide resolved
plugins/inputs/opentelemetry/opentelemetry.go Outdated Show resolved Hide resolved
plugins/inputs/opentelemetry/grpc_service_profile.go Outdated Show resolved Hide resolved
@powersj powersj assigned srebhan and unassigned DStrand1 Aug 7, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 7, 2024

@srebhan srebhan merged commit 8903637 into influxdata:master Aug 9, 2024
27 checks passed
@srebhan srebhan deleted the opentelemetry_profiles branch August 9, 2024 08:42
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants