-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.opentelemetry): Add profiles support #15637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for jumping on this! Let's get this in and get some feedback from users.
This will also need a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one tiny comment
4b57893
to
c2f21db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Later, you might want to move some of this to https://github.com/influxdata/influxdb-observability but I think this is a good place to try it out.
c2f21db
to
de64cd8
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
This PR adds support for (still experimental) OpenTelemetry profiles making Telegraf the world's first collector to support it. ;-)
As a side effect, the unit-tests are extended to allow for general test-cases to be added similar to other plugins.
Tests were performed using the Elastic otel-profiling agent.
Checklist
Related issues