Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): Add 'trace' log-level #15695

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 31, 2024

Summary

Add a trace log-level below the existing debug one to be able to trace plugin internal messages such as connection debugging etc potentially producing large amounts of messages. Please note, currently there is no means to enable this on an agent-wide scale. This is intentionally!

The PR furthermore, converts several plugins to use the new log-level instead of home-brewed settings.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 31, 2024
@srebhan srebhan added area/logging ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jul 31, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you so much!

@powersj powersj removed their assignment Jul 31, 2024
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, cleans up a lot of disconnect trace configs!

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Jul 31, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan merged commit d160276 into influxdata:master Jul 31, 2024
27 checks passed
@srebhan srebhan deleted the log_trace_level branch July 31, 2024 22:32
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants